Comment Search

Remove extra blank line.

Done.

Put test functions at bottom of module (after usual banner).

Reverted the code with timeout. Need to add timeout requirement in the Inlet Water Check in the DG SRS.

Done.

struct.py lists the args to unpack as such:

"The remaining chars indicate types of args and must match exactly;
these can be preceded by a decimal repeat count:
x: pad byte (no data);
c:char;
b:signed byte;
B:unsigned byte;
?: _Bool (requires C99; if not available, char is used instead)
h:short;
H:unsigned short;
i:int;
I:unsigned int; (Capital i)
l:long;
L:unsigned long;
f:float;
d:double;
e:half-float."

Rotor_count is sent from the HD as an unsigned int (U32).

It has only one parameter and is 15 bytes long.
By definition, it is different than the others.

Removed the lines
requestConcentratePumpOff( CONCENTRATEPUMPS_CP1_ACID );
requestConcentratePumpOff( CONCENTRATEPUMPS_CP2_BICARB );

The concentrate pumps are already OFF prior to transitioning to produce dialysate state.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Required to display the Alarm Top on the diagnostic screen

Why do we need the second part of this condition? When we start wet self tests, bolus volume delivered should be zero.

Fixed. Thanks!

Not sure why we need stopPump flag - can't we just call the check function w/ no parameters?

I forgot the pumps run at 48 mL/min not 48 mL/sec.

total line volume + 25% = 60mL + 25% of 60mL = 75 mL.

Concentrate pumps run at 48 mL/ min.

( 75 mL / 48 mL ) * 60 seconds = 93.75 seconds (used 95 seconds for PRIME_CONCENTRATE_LINES_TIME_OUT_MS)

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

Fix indenting here.

Indent comment properly.

Is this alarm really logged to treatment log?

I think the data are floats, so 0 should be 0.0.

Check that Dialin has logged in before acting on a Dialin request (TRUE == isTestingActivated()).

RESOLVED in CODE WALKTHROUGH.

Check editor settings. Tabs should be set to 4 spaces.

RESOLVED in CODE WALKTRHOUGH.