Comment Search

RESOLVED in CODE WALKTHROUGH.

Remove extra space after F32.

Is DG needed?

Done

Done.

RESOLVED in CODE WALKTHROUGH.

Need to have 2 blank lines.

Need function header.

Do we need a debounce on the switch before changing state?

Updated.
In UI Software we also have different TODO flags like TEST, DEBUG, FIXME, and so on.
In this case, I used TEST.

Updated.

RESOLVED.

Added.

RESOLVED in CODE WALKTRHOUGH.

I don't think we should have a default for the packing in this case. I think the packing type should be provided, like I need 'i' I will provide 'i' and if someone else wants 'I' then it should be provided. Although the number of bytes of b and B are the same, but it should be up to the developer to provide which of they want. Also, for safety we should add the '<' to make sure the little endianness is definitely enforced. For instance it is '<i" and not just 'i'.

RESOLVED.

Line 489 F32 bolusVol = getTreatmentParameterF32() was moved. it is no longer here.

RESOLVED in CODE WALKTHROUGH.

Separate functions have been created to keep the string representations clearer.
It is not safe to use something like "b" or "B" since anyone can even but something like "hello" which probably doesn't mean anything and is an error.
to overcome this flow the different functions implemented here have to be used.

Also since the intention of the function here is clear the length has been calculated regarding the type conversion in each function.
which helps have a lot of clearer code.
Please refer to the usage in:
d9b45e5b52db2540a79cbc8795d82dda4fd3984b on dialin develop branch.

the code has changed from:

        major = struct.unpack('B', bytearray(
            message['message'][self.START_POS_MAJOR:self.END_POS_MAJOR]))
        minor = struct.unpack('B', bytearray(
            message['message'][self.START_POS_MINOR:self.END_POS_MINOR]))
        micro = struct.unpack('B', bytearray(
            message['message'][self.START_POS_MICRO:self.END_POS_MICRO]))
        build = struct.unpack('H', bytearray(
            message['message'][self.START_POS_BUILD:self.END_POS_BUILD]))
        compatibility = struct.unpack('H', bytearray(
            message['message'][self.START_POS_COMPAT:self.END_POS_COMPAT]))

which was so error-prone to the following code:

        major, index = bytearray_to_byte(payload, index, False)
        minor, index = bytearray_to_byte(payload, index, False)
        micro, index = bytearray_to_byte(payload, index, False)
        build, index = bytearray_to_short(payload, index, False)
        compt, index = bytearray_to_integer(payload, index, False)

This looks backwards. double should be 8, float should be 4.

RESOLVED.

Mention what rate is being overridden here (Heparin bolus rate).

Dara Navaei Please take a look.

Renamed #define to

#define MIN_WATER_TEMPERATURE_WARNING_LOW_RANGE 22U
#define MAX_WATER_TEMPERATURE_WARNING_LOW_RANGE 24U
#define MIN_WATER_TEMPERATURE_WARNING_HIGH_RANGE 37U
#define MAX_WATER_TEMPERATURE_WARNING_HIGH_RANGE 39U
#define MIN_WATER_TEMPERATURE_ALARM 22U
#define MAX_WATER_TEMPERATURE_ALARM 39U

I uncommented the code. I will continue monitoring this error to see if it occurs again.