•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-9054-1 29 Jul 2021

Done.

DG-DEN-9054-1 29 Jul 2021

This function is called during POST to get all the pertaining calibration data but since the modes do not have have POST states, it was decided to use DrainPump.c to get the calibration information.

DG-DEN-9054-1 29 Jul 2021

If the calibration data is invalid, the function will raise an alarm. But the all the calibration records that fail CRC test will be in benign values by NVDataMgmt.c so the benign value is taken as the target flush volume.

DG-DEN-9054-1 29 Jul 2021

Fixed it.

DG-DEN-9054-1 29 Jul 2021

I removed the enum.

DG-DEN-9054-1 29 Jul 2021

Done.

DG-DEN-9054-1 29 Jul 2021

What happens when calibration data is invalid?

HD-DEN-9054-1 30 Jul 2021

Should initialize the other elements of the override structure too. Most importantly, the override flag should be off.

HD-DEN-9054-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9054-1 30 Jul 2021

Can we move these 2 lines of code down where the other ADC channels are being read and converted?

UI-DEN-8705-1 06 Aug 2021

RESOLVED.

HD-DEN-8679-1 09 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 09 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8534-1 11 Aug 2021

Done.

HD-DEN-8534-1 12 Aug 2021

Done.

HD-DEN-8534-1 12 Aug 2021

Done.

DG-DEN-11114-1 04 Jan 2022

Why is this code commented out?

UI-DEN-9411-1 12 Aug 2021

Why not - 40? Can we remove?

UI-DEN-9411-1 12 Aug 2021

Comment doesn't match code.

UI-DEN-9411-1 12 Aug 2021

Added.

UI-DEN-9411-1 12 Aug 2021

Added.

HD-DEN-8534-1 12 Aug 2021

Move switch and temp monitors up above execOperationModes().

HD-DEN-8534-1 12 Aug 2021

ModeStandby.h already included above. Keep list alphabetized.

DG-DEN-7802-1 12 Aug 2021

Is there a problem with this alarm? Add TODO?

DG-DEN-7802-1 12 Aug 2021

Why commented out?

UI-DEN-9411-1 12 Aug 2021

Missing brief for these methods.

DG-DEN-11114-1 04 Jan 2022

Blank line between declaration and code.
Fix indentation.
Fix magic number 1000.0.

HD-DEN-11114-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 04 Jan 2022

Done.

DG-DEN-11114-1 04 Jan 2022

This was commented out for the performance and to make sure the trimmer heater is not running.

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 04 Jan 2022

Should these come from calibration record or ok to hard code?

UI-BUG-S62-1 26 Jan 2022

RESOLVED.

HD-DEN-11250-1 31 Jan 2022

Bolus time obsolete.

HD-DEN-11250-1 01 Feb 2022

RESOLVED in CODE WALKTHROUGH.

UI-BUG-S62-1 26 Jan 2022

Why commented out?

DG-DEN-13460-2 22 Sep 2022

RESOLVED in CODE WALKTHROUGH.

RO-LDT-1242-1 03 Sep 2025

it was place holder until blood leak alarms are were in staging. its in order now.

DG-DEN-7568-1 19 Apr 2021

This is for the initial estimation. This has changed during the revisit of the RO pump module.

UI-DEN-12121-1 02 Mar 2022

It has been defined in the AlarmItem.
Expose the VAlarmStatus property from AlarmItem.qml by adding this line:

    readonly property alias alarm_AlarmID : vAlarmStatus.alarm_AlarmID


then use the AlarmItem object, (which has been defined in the main.qml) to get the alarm id like the line below:

_alarmItem.alarm_AlarmID


Thanks,

DG-DEN-11928-1 01 Mar 2022

Updated code to include checking for high conductivity

DG-DEN-7568-1 19 Apr 2021

These are the inputs that are changed in this function. Is this not right?

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12121-1 02 Mar 2022

This needs to be updated to 10 * 4 if the change to the "TreatmentStates" is approved by Sean Nash.
Also please remove the duplicate.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 08 Apr 2021

Preferred architecture is to just set a request flag here and then let your state machine see the flag and change the state and command the FPGA action the next time it executes.

HD-DEN-8679-1 27 Jul 2021

This message is requested by UI. UI wants to keep it consistent with other request message, in case there is reject reason in the future.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12121-1 02 Mar 2022

This message has been defined with 5xF32 parameters.

0x3100 49 0x080 1 Hz N DG All DG Conductivity Data (F32) RO rejection ratio (F32) CPi conductivity (F32) CPo conductivity (F32) CD1 conductivity (F32) CD2 conductivity