•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-8534-1 11 Aug 2021

Done.

HD-DEN-8534-1 11 Aug 2021

Done.

HD-DEN-8534-1 11 Aug 2021

Wrong alarm id.

UI-DEN-9411-1 12 Aug 2021

No comment?

HD-DEN-8534-1 12 Aug 2021

Make this a declaration and remove declaration above loop.

UI-DEN-9411-1 12 Aug 2021

Removed.

UI-DEN-9411-1 12 Aug 2021

Updated.

UI-DEN-9411-1 12 Aug 2021

Magic number?

DG-DEN-5963-1 18 Apr 2021

The above code has been deleted.

DG-DEN-7802-1 23 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11750-1 01 Mar 2022

?

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

reverted this

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 29 Jul 2021

RESOLVED in CODE WALKTRHOUGH.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 18 Apr 2021

Is load cell A1 with A2, and B1 with B2?

DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7395-1 19 Apr 2021

Looks like copy from fluid leak class. Update for blood leak.

DG-DEN-5963-1 19 Apr 2021

I removed the = sign.

DG-DEN-5963-1 21 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7568-1 23 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7568-1 21 Apr 2021

Update to latest revision. This function should be deleted.

DG-DEN-7568-1 23 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 27 Jul 2021

Done. I prefer generally output description, so refactor is easier. Normally, a refactor will often make these variables in the doxygen comment obsolete (variable name change).

HD-DEN-7347-1 25 Apr 2021

Done.

HD-DEN-7347-1 25 Apr 2021

Will this variable be ever used?

HD-DEN-7347-1 25 Apr 2021

For consistency, I recommend reversing the second part of and in the if statement.

HD-DEN-8679-1 27 Jul 2021

It is part of background task in the battery monitor exec function. The initial value is 0, we will wait here till we get status.

DG-DEN-9054-1 28 Jul 2021

The default pump control mode is none.

DG-DEN-9054-1 29 Jul 2021

Should it be 0 and is the first one in the enumeration?

DIALIN-DEN-8030-1 29 Jul 2021

I added them.

UI-DEN-8705-1 06 Aug 2021

RESOLVED.

HD-DEN-8679-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 29 Jul 2021

RESOLVED in CODE WALKTRHOUGH.

DG-DEN-9054-1 26 Jul 2021

Compatibility check should be before FPGA test at end where it was. We can't do it this early because UI may not have provided us with version/compatibility info yet.

DIALIN-DEN-8030-1 29 Jul 2021

Done.

DG-DEN-9054-1 30 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 29 Jul 2021

Do we need to add copyrights or bamboo will do it?

DG-DEN-9054-1 29 Jul 2021

Should this function move to ModeRecirculate? It does not seem to contain any information related to drain pump.

HD-DEN-9054-1 31 Jul 2021

FPGA only debounces for 50ms. I added code to debounce for a longer period of time.

HD-DEN-9054-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9054-1 29 Jul 2021

It is both in develop branch and staging branch for fwcommon.

HD-DEN-8679-1 02 Aug 2021

Fixed.

DG-DEN-9054-1 04 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 06 Aug 2021

Removed.

DG-DEN-7802-1 06 Aug 2021

Done.