•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-8886-1 12 Aug 2021

What is the plan with these software faults?

HD-DEN-8534-1 11 Aug 2021

Should be HD FAN alarm

DG-DEN-7802-1 12 Aug 2021

Change large to small in brief.
Why is this changing? Who calls this function?

UI-DEN-9411-1 12 Aug 2021

Comment doesn't match code.

UI-DEN-9411-1 12 Aug 2021

Missing brief.

HD-DEN-8534-1 12 Aug 2021

Maybe renamed. Should not be removed.

UI-DEN-9411-1 12 Aug 2021

Updated.

UI-DEN-9411-1 12 Aug 2021

Updated.

UI-DEN-9411-1 12 Aug 2021

Why commented out? Can we remove?

UI-DEN-9411-1 12 Aug 2021

RESOLVED.

UI-DEN-9411-1 12 Aug 2021

RESOLVED.

UI-DEN-9411-1 12 Aug 2021

RESOLVED.

UI-DEN-9411-1 12 Aug 2021

Comment doesn't match code.

HD-DEN-8534-1 11 Aug 2021

Wrong alarm id.

HD-DEN-8534-1 11 Aug 2021

Change it to ALARM_ID_TREATMENT_STOPPED_NO_RINSEBACK.

HD-DEN-8886-1 09 Aug 2021

Suggest define magic number 0.

HD-DEN-8886-1 11 Aug 2021

I do not see this variable in the function.

DG-DEN-7802-1 12 Aug 2021

Do we need this state? What's difference between the 2 states now that VDr is never recirculating?

DG-DEN-7802-1 12 Aug 2021

Why needed?

UI-DEN-9411-1 12 Aug 2021

Should this be 1 * 15 for consistency?

DG-DEN-5963-1 18 Apr 2021

Done.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 12 Aug 2021

Is ADC range check necessary?

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 24 Mar 2021

Do we need a get function for determining if/when zero is done? And another for determining if self-test passed/failed?

DG-DEN-13460-2 22 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7395-1 19 Apr 2021

Addressed.

DIALIN-DEN-7395-1 19 Apr 2021

Addressed.

DIALIN-DEN-7395-1 19 Apr 2021

Add another class variable for state.

UI-DEN-9411-1 12 Aug 2021

Updated.

DIALIN-DEN-7792-1 21 Apr 2021

Done

DG-DEN-7568-1 14 Apr 2021

I think this is actually a time stamp for when flush mode began - and you are using it to calculate total flush mode elapsed time. I would add the word "Start" to the end of the variable name and clarify the comment.
stateTimer below is likely also a starting time - so same comment.

HD-DEN-8679-1 26 Jul 2021

Why not zero record here? I see it is zeroed just prior to creation at end of treatment, but that means this record may have prior treatment's data until current treatment is over.

DG-DEN-7568-1 22 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7568-1 23 Apr 2021

Yes, this was on hold. I updated it.

HD-DEN-8679-1 27 Jul 2021

Fixed.

HD-DEN-7347-1 25 Apr 2021

This function needs a header.

SRVC-DEN-7335-1 21 Apr 2021

Agreed - I don't want them to have to guess the type. At the time the dropdown was really a backup option in case the type hints approach wasn't feasible. Currently in a difference branch I'm in the process of upgrading the service app to provide type hints for each command to make it easier for the user.

HD-DEN-8679-1 27 Jul 2021

If fault mode calls the treatment log data collect function, the record can be zeroed also.

DG-DEN-9054-1 28 Jul 2021

Done.

DG-DEN-9054-1 28 Jul 2021

Done.

HD-DEN-8679-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 29 Jul 2021

RESOLVED in CODE WALKTRHOUGH.

HD-DEN-8679-1 29 Jul 2021

RESOLVED in CODE WALKTRHOUGH.

DG-DEN-9054-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 29 Jul 2021

Done.

DG-DEN-9054-1 30 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 30 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8030-1 26 Jul 2021

These defs should be moved to common/dg_defs.py