•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 26 Jul 2021

If typical h/w response is very quick (e.g. < 1ms) and worst case is still pretty quick (e.g. < 5ms), then I think this is ok with the t/o there to prevent getting stuck in loop forever.
Also, battery monitor is called from background task so we can be a little more relaxed about this.

DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7395-1 19 Apr 2021

RESOLVED.

DIALIN-DEN-7395-1 19 Apr 2021

RESOLVED.

DIALIN-DEN-7395-1 19 Apr 2021

Remove this constraint.

DIALIN-DEN-7395-1 19 Apr 2021

Change "priority" to "general" and 10ms to 50ms.

DG-DEN-5963-1 19 Apr 2021

Should we remove = so we only error when greater than?

SRVC-DEN-7335-1 21 Apr 2021

RESOLVED.

DG-DEN-7568-1 21 Apr 2021

Should result be set the the return of startDGFlush() and stopDGFlush() functions?

DG-DEN-7568-1 23 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 24 Jul 2021

How do you get the status of the battery charge in the self test before you check the whether it is in range?

DG-DEN-9054-1 27 Jul 2021

So these & operators are going to yield a zero or a non-zero number that will be different for each switch (not a boolean). I think your intent is for these switch data to be an enum. So, for example, this one should be "... = ( ( fpgaRegister & CONCENTRATE_CAP_SWITCH_BIT_MASK ) != 0 ? OPEN : CLOSED );

HD-DEN-7347-1 25 Apr 2021

For consistency, I recommend reversing the second part of and in the if statement.

DG-DEN-9054-1 30 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 27 Jul 2021

The else is when AC power detected. Added clear alarm condition.

HD-DEN-8679-1 27 Jul 2021

The transition function will call this init function.

DG-DEN-9054-1 28 Jul 2021

Done.

DG-DEN-9054-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 29 Jul 2021

Done.

HD-DEN-8679-1 26 Jul 2021

I think this will be the time we initiate a treatment. Is that what we want? Or should we move this to transition function to capture time of treatment start?

DG-DEN-9054-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 29 Jul 2021

Done.

DG-DEN-9054-1 29 Jul 2021

Done.

DG-DEN-9054-1 29 Jul 2021

Need to add a check if switchId is in valid range.

DG-DEN-9054-1 30 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8856-1 29 Jul 2021

In this filename, "prs" means "Product Requirement Specification" and not "Pressure".
These values are defined in the PRS and are being used by UI Simulator.

DG-DEN-9054-1 29 Jul 2021

The comment is out-date and need to be updated.

DG-DEN-9054-1 04 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9054-1 30 Jul 2021

That is right. I removed the parameter.

DG-DEN-9054-1 31 Jul 2021

The signal is debounced for 50ms. I added a debounce for a longer time.

HD-DEN-9054-1 31 Jul 2021

I merged staging and uncommented the function.

DG-DEN-9054-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9054-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9054-1 30 Jul 2021

Caps?

HD-DEN-9054-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 03 Aug 2021

Done.

DG-DEN-9054-1 03 Aug 2021

Looks like the parameter is not being used.

DG-DEN-9054-1 03 Aug 2021

maxBufferLength variable is not needed in this case and the comment is not matched the code.
Suggest revert this change to line 2139.

HD-DEN-8679-1 06 Aug 2021

Done.

DG-DEN-7802-1 06 Aug 2021

Added a define.

UI-DEN-8705-1 06 Aug 2021
UI-DEN-8705-1 06 Aug 2021

RESOLVED.

HD-DEN-8534-1 11 Aug 2021

Done.

HD-DEN-8534-1 11 Aug 2021

Done.

HD-DEN-8534-1 11 Aug 2021

Done.

DG-DEN-5963-1 18 Apr 2021

Done.