•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-11114-1 04 Jan 2022

Remove blank line here.

DG-DEN-11928-1 01 Mar 2022

RO pump rate is already set in the previous state.

UI-BUG-S62-1 19 Jan 2022

There has to be and there is.
It is just a long line and those little ones are at the end.

DIALIN-UI-S63-1 08 Feb 2022

These are all the same changes from

http://dvm-linux02:8060/cru/DIALIN-BUG-S63-1

DG-DEN-11750-1 02 Mar 2022

Done.

HD-DEN-11250-1 31 Jan 2022

Done. Removed bolus time HEPARIN_BOLUS_TIME_HR.
Also removed bolus time HEPARIN_BOLUS_TIME_HR in function handleSyringePumpSeekState()
F32 hepDurHr = ( (F32)( setTxDur - preStop ) / (F32)MIN_PER_HOUR ) - HEPARIN_BOLUS_TIME_HR;

HD-DEN-11250-1 01 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11250-1 28 Jan 2022

I think we should say end of seek or before prime instead of start of priming.

DG-DEN-11750-1 02 Mar 2022

You are right. I removed the code.

DIALIN-BUG-S63-1 01 Feb 2022

RESOLVED.

UI-BUG-S62-1 18 Jan 2022

It seems you have multiple else statements that do the same, is that right? If yes, why multiple elses?

UI-BUG-S62-1 26 Jan 2022

Why commented out?

DIALIN-UI-S63-1 08 Feb 2022

These are all the same changes from

http://dvm-linux02:8060/cru/DIALIN-BUG-S63-1

UI-DEN-12121-1 02 Mar 2022

it has already been defined, this would be a duplicate handler.
why do we need to have the top on diagnostics while it has to always be on alarm dialog/bar on screen?

UI-DEN-12121-1 02 Mar 2022

Users can not see the alarm screen when the diagnostics screen is visible. This was a request by systems in DEN-12118. Is there another approach to this?

DIALIN-UI-S63-1 14 Feb 2022

You are right,
It is just a temporary fix to make the API work with the current UI which is not updated to the latest Messages list, for the LTTS to get them unblocked.
As part of the LTTS support and the messages list update/sync it will be removed/fixed.

DG-DEN-11928-1 28 Feb 2022

Put "none" in function headers where there is nothing in that section (throughout this module).

UI-BUG-S63-2 15 Feb 2022

RESOLVED.

HD-DEN-11250-1 15 Feb 2022

Done.

DG-DEN-11928-1 01 Mar 2022

According to SRSDG 397 we need to check the dialysate temperature within +/- 2 deg C.
Systems need to review the DGSRS and provide comments.

HD-DEN-11750-2 02 Mar 2022

Check payload length is at least 12.

HD-DEN-11250-1 15 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11250-1 15 Feb 2022

Can we move this function up above with the other get functions? And update the other get functions to use the common get override value function like this one does.

DG-DEN-11928-1 28 Feb 2022

Do both lines prime in same amount of time? Are volumes same? Is 2 seconds the right amount of time?

HD-DEN-11250-1 15 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11250-1 31 Jan 2022

I think DEN-11750 branch has a better version of this code. Reconcile this code with DEN-11750.

DG-DEN-11928-1 22 Mar 2022

Moved check for empty bottles before if ( TRUE == isReservoirTarePending() )

DG-DEN-11928-1 23 Mar 2022

Added
genIdleState = DG_GEN_IDLE_MODE_STATE_START;

DG-DEN-5963-1 15 Apr 2021

I brought it back.

DG-DEN-13460-2 22 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 22 Jul 2021

Done.

DG-DEN-5963-1 15 Apr 2021

I changed the publish interval to 1 second. I also removed the extra parentheses.

HD-DEN-13460-2 22 Sep 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

No action item.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

HD-DEN-7395-1 15 Apr 2021

Addressed.

DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 16 Apr 2021

Done.

DG-DEN-5963-1 16 Apr 2021

Done.