•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-11114-1 04 Jan 2022

Comment doesn't match code (1 vs 2 degrees).
What is the TODO here? Is this temporary code?

DG-DEN-11114-1 04 Jan 2022

I think we have macros in common.h to do this kind of thing.

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 05 Jan 2022

RESOLVED IN CODE WALKTHROUGH

UI-BUG-S62-1 19 Jan 2022

RESOLVED.

UI-BUG-S63-2 15 Feb 2022

RESOLVED.

UI-BUG-S62-1 26 Jan 2022

What is the purpose of this alias?

HD-DEN-11250-1 31 Jan 2022

Done.

HD-DEN-11250-1 31 Jan 2022

Moved startHeparinBolus() in transitionToWetSelfTests() to handleWetSelfTestStartState().

HD-DEN-11250-1 31 Jan 2022

Done. Removed the 2nd part ( && ( getSyringePumpVolumeDelivered() < bolusVol )

HD-DEN-11250-1 31 Jan 2022

Removed checkForPrimeEmpty().

HD-DEN-11250-1 31 Jan 2022

Removed bolus range check.

HD-DEN-11250-1 31 Jan 2022

Reversed the code to the original.
Now, implemented check for occlusion in SelfTests.c

HD-DEN-11250-1 31 Jan 2022

Reversed the code to the original.
Uncommented result = SYRINGE_PUMP_OFF_STATE;

HD-DEN-11250-1 01 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11250-1 31 Jan 2022

Remove this blank line. Cannot make changes outside user code blocks.

HD-DEN-11250-1 31 Jan 2022

Need to uncomment this now that testing is done.

HD-DEN-11250-1 31 Jan 2022

I don't think this will work. When you stop pump above, you will leave this state, so you will never get into the if condition below.
I think the 1 second delay and check for occlusion should be handled in the SelfTests.c.

HD-DEN-11250-1 01 Feb 2022

RESOLVED in CODE WALKTHROUGH.

UI-BUG-S63-2 14 Feb 2022

This is part of an ongoing investigation on how to fix the slider touch margin issue.
I am still working on it.
It worked somehow for the slider with lower resolution but for sliders, with a high resolution, it causes a handler jump which makes it less user-friendly.
Added clarifying comment.

UI-BUG-S63-2 08 Feb 2022

If not needed, why not just delete this line?

UI-BUG-S63-2 15 Feb 2022

RESOLVED.

UI-BUG-S63-2 08 Feb 2022

Why commented out?

DIALIN-UI-S63-1 15 Feb 2022

RESOVLED

HD-DEN-11250-1 15 Feb 2022

Remove extra blank lines.

DIALIN-DEN-11980-1 16 Feb 2022

Should the new current treatment params above be reset in this function?

DG-DEN-7802-1 22 Jul 2021

Done.

DG-DEN-5963-1 15 Apr 2021

The alarm is different for each condition, so that explains what failed and in what state (i.e reservoir drain time out in drain R1 state)

UI-DEN-11980-1 16 Feb 2022

align the

.value
DG-DEN-7802-1 23 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11980-1 16 Feb 2022

Remove blank line.

DG-DEN-7802-1 23 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11980-1 16 Feb 2022

Add one more blank line here.

DG-DEN-7802-1 23 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11980-1 16 Feb 2022

Remove extra blank lines.

UI-DEN-8705-1 23 Jul 2021

RESOLVED.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

updated per meeting last week

HD-DEN-8679-1 26 Jul 2021

Why would we zero it when no AC detected?

HD-DEN-11250-1 31 Jan 2022

Yes, we use fixed rate. Removed min/max bolus rates

DG-DEN-11750-1 01 Mar 2022

?

HD-DEN-8679-1 26 Jul 2021

Not sure this variable (and related get function) are needed.

HD-DEN-8679-1 26 Jul 2021

User may not have changed all 4 settings. Should we only send events for those that actually changed?

DG-DEN-9054-1 26 Jul 2021

For consistency, can we put Dialin functions at end?

DG-DEN-9054-1 26 Jul 2021

How is this used?

HD-DEN-11098-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-10602-1 04 Jan 2022

fixed.

DG-DEN-11114-1 04 Jan 2022

Done.

DIALIN-DEN-11114-1 05 Jan 2022

Done.

DG-DEN-11114-1 04 Jan 2022

Add blank line between declarations and code.

DG-DEN-11114-1 04 Jan 2022

Yes, I think we do need to check efficiency.