RESOLVED in CODE WALKTHROUGH.
I think "full" should be changed to target volume reached. Review function header descriptions for any updates needed.
Recommend making this variable name a little more descripting. Something like alarmDetectedPendingTrigger.
This function has no inputs. It only sets variables. It never references any.
I changed it to one line.
Remove blank line.
fabs will indicate a leak even if the volume goes up. Is that what you want here?
This resets any previous command response that has not been processed for this specific command.
Old style Set/Reset functions. Update to new style with message as parameter and handles both set and reset.
Should return boolean. Should return FALSE and not request standby if we are not in heat disinfect mode.
We're making all comments start with a capital letter globally. I did HD. This is probably the branch that we should do same for DG.
Remove this one. This has been handled at line 1679.
The minimum is not needed and I removed it.
Done. This is a temporary variable and it will be removed.
RESOLVED.
Add TODO
VSP should only be on when user requests to sample water.
Done.
Should use OVERRIDE_RESET (which is 0) here.
fixed
Use () for the multiplication part.
To make sure the order of math operations are correct, we should have () around the items that are multiplied and then divide it to the treatment duration.
I will bring efficiency back in DEN-11750.
I will bring this back in DEN-11750.
I will remove this in DEN-11750. This is still used for data collection.
Removed the comment.
This comment seems redundant.
Let's decide this now and remove TODO.
Can we remove this now?
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
