•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5963-1 14 Apr 2021

It depends on where it is going. If it is the last drain, it turns off the drain pump.

DG-DEN-13460-2 22 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 14 Apr 2021

The global check has been removed. PPi is checked here.

HD-DEN-8030-1 28 Jun 2021

Why do all of these POST tests have these #ifdefs? They don't appear to have anything to do with NV POST.

DG-DEN-5963-1 14 Apr 2021

Done.

HD-DEN-8030-1 01 Jul 2021

Why deleted?

HD-DEN-8030-1 07 Jul 2021

RESOLVED in CODE WALKTHROUGH.

LEAHI-DD-FIRMWARE-LDT-2198-1 15 Sep 2025

Read FPGA D6 status once at top of D6 if statement into a local var and use that in these if conditions so you don't have to keep calling the fpga function.

DG-DEN-7568-1 14 Apr 2021

Didn't these RO pump control changes happen a long time ago? Why are they showing up here as new changes?

DG-DEN-7568-1 14 Apr 2021

Is this function something we can have just once somewhere? I feel like this same function is going to be in both disinfect modes and this flush mode.

DIALIN-DEN-8856-1 09 Jul 2021

Add TODO

DIALIN-DEN-8856-1 19 Jul 2021

RESOLVED.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7568-1 14 Apr 2021

Why did this change so much? This is for the initial PWM estimate, right?

DG-DEN-7568-1 14 Apr 2021

Yes, the exact same function is used in heat disinfect and one will be used in chemical disinfect. Where do you suggest we should put them?

DG-DEN-7802-1 21 Jul 2021

If HD is not communicating, should we got transition to standby solo mode?

UI-DEN-10205-1 03 Jan 2022

RESOLVED.

DG-DEN-5963-1 22 Mar 2021

This comment needs a rephrase. I don't think range has anything to do with it. This is a retry counter check.

DG-DEN-7568-1 14 Apr 2021

Not necessary. Standby mode is going to set actuators on entry 50ms from here so why bother.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 22 Mar 2021

Can drain time out in this state? Why no check?

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 22 Mar 2021

Are these the only two faults that can happen in R1 to R2 state?

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 22 Mar 2021

Check boolean explicitly.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 22 Mar 2021

I prefer boolean conditions be explicit (e.g. TRUE == isThisLastDrain). This way, if value gets corrupted to a garbage value (like 5) it will be same as FALSE.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 04 Jan 2021

I don't see that you're using this status type. Why not just remove it now?

DG-DEN-5963-1 04 Jan 2021

Should drain pump be turned off?

DG-DEN-5963-1 04 Jan 2021

Function name is confusing. Change to something like failHeatDisinfection(). Also, this state handler will return DG_HEAT_DISINFECT_STATE_DRAIN_R1 - overriding the complete state being set in your function.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 04 Jan 2021

I would avoid the \ and new line here. If comment won't align, put comment on line above with ///.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 04 Jan 2021

Should this return a boolean? What if we're not in heat disinfect mode when this function is called? Should return FALSE then.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.