This is just to check that everything above minimum we are about to start the heat disifnect mode. I added the max limit too.
Done.
The #ifdefs are for making sure NV POST and all the other POSTs that necessary like the HD valves are done but the rest are skipped.
Mismatch filename.
Sean Nash please reply.
Done
Removed in the current working code. Will be reviewed in the next review.
RESOLVED.
I will address this comment in DEN-9054 (switches) branch.
RESOLVED in CODE WALKTHROUGH.
When are these commandIDs set to anything else?
CAN instead of can
Denali with capital "D".
The getter from non-volatile module is in my branch.
In DG standby mode, DG will transition to solo mode.
VSP is never open until this state is done. The endSampleWaterRequest is for the user presses the stop button during the filter flush and end treatment, allowing DG to go back to standby idle state.
This should be flush filter idle state.
Are we supposed to switch to water sample state? This does not go to water sample state.
Remove 2nd "the"
Add the doxygen comment.
Why is there a magic number here?
I will add this in DEN-11750.
If no test support functions, remove this banner.
Why not publish new time offset?
I'm not understanding why + 1 is needed for these.
Looks like we're getting a lot more than these 3 values in this function. Shouldn't we publish everything?
Is this build switch still used?
The file is removed.
Done. Removed max bolus rate.
The declaration in the header file has const for all 3 parameters.
Updated other get functions to use common get override function. Added getS32, getU32, and getU08 override functions.
Do not change data - should always be 40.0 as initialized.
Set ovData to ovInitData before zeroing it.
No parameter needed in this function.
I believe this was caused from us branching out of master to have develop & staging branches for common. I will review this as this was not expected.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
