Comment Search

???

Couldn't find time to investigate more on this,
So created a task for later code cleanup and refactoring.
http://dvm-linux02:8080/browse/DEN-12031

Not sure if check for prime empty makes sense. An insufficient Heparin alarm should always occur first, so empty check would be unreachable.

RESOLVED in CODE WALKTHROUGH.

Fixed.

Header suggests there are only 2 parameters. What is this 3rd param and why is it zero?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Add a blank line between declarations and code.

Not a great name. Should be resFull or something like that.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Why does it look like you added this table when I know it was there before?

setAirPumpState could return a BOOL (FALSE if range check fails or state invalid) that you can set result to.

RESOLVED in CODE WALKTHROUGH.

I think we still need this alarm. There should be 2 alarms. One for alarm (>=2200) and one for warning (>=2000 and <2200).

Should we close both drain valves VRd1 and VRd2 here?

Why are DG definitions in HDDefs.h? If needed by both stacks, should we create a FWDefs.h common to both f/w stacks?

Done.

Insert a space between the last '0' and '}' in OVERRIDE_32_T type.

Checked with Systems. Conductivity min value is 100.
#define COND_SENSOR_CPI_MAX_VALUE 2200
#define COND_SENSOR_CPI_WARNING_HIGH 2200
#define COND_SENSOR_CPI_WARNING_LOW 2000
#define COND_SENSOR_CPI_MIN_VALUE 100

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.