•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-11114-1 04 Jan 2022

I think we need to restore this code.

UI-DEN-12182-2 02 Mar 2022

Do we need to keep these legacy files at all?

DG-DEN-11928-1 28 Feb 2022

testValue is a parameter - not an input. There are 2 other parameters. Need to add @param for each.

HD-DEN-11250-1 31 Jan 2022

Done.

HD-DEN-11250-1 31 Jan 2022

Why is this commented out? If alarm, need to leave this state (and go to off state).

HD-DEN-11250-1 01 Feb 2022

RESOLVED in CODE WALKTHROUGH.

UI-BUG-S62-1 19 Jan 2022

That is a very good point.
No one ever mentioned that.

Let me investigate, why I had all these repeated else.
Could be for performance not to check next, but there is another way for that too.
If I can't find a quick answer for that let me create a case for that since it is everywhere.

DIALIN-UI-S63-1 14 Feb 2022

Great catch,
Thanks, fixed.
Fortunately, it wasn't being used anywhere.

HD-DEN-11250-1 01 Feb 2022

Updated handlePOSTStateStart( ) function with the handlePOSTStateStart( ) used in DEN-11750.

UI-BUG-S62-1 01 Feb 2022

The Arterial and Venous sliders are RangeSlider and are handled differently.
The extra code is removed.

UI-BUG-S62-1 01 Feb 2022

matched.

UI-BUG-S62-1 01 Feb 2022

RESOLVED.

UI-BUG-S62-1 02 Feb 2022

RESOLVED.

DIALIN-BUG-S63-1 02 Feb 2022

RESOLVED.

UI-BUG-S62-1 26 Jan 2022

File name does not appear to match image.

HD-DEN-11250-1 15 Feb 2022

Removed the line #include "reg_crc.h"

HD-DEN-11250-1 15 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11250-1 15 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11250-1 31 Jan 2022

Add a blank line between declarations and code.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-11250-1 16 Feb 2022

I don't see a df_object anywhere - I don't think this comment makes sense.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 04 Jan 2021

Instead of "if the flag is TRUE", comment should say something like "if disinfect temperature has been reached".

DG-DEN-7802-1 22 Jul 2021

Done.

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-11980-1 16 Feb 2022

Please change name of the file(s) to:
MTreatmentDialysateFlowData.[h,cpp]
Inlet => Dialysate

DG-DEN-5963-1 15 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-11114-1 05 Jan 2022

Done.

HD-DEN-11250-1 16 Feb 2022

Why deleted?

DG-DEN-7802-1 22 Jul 2021

Added back alarm.

DG-DEN-7802-1 23 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 10 Jun 2021

I think we should not stop RO pump or heater. Just go to drain like production state (but no mixing).

DG-DEN-7802-1 23 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 28 Feb 2022

These 2 rates look strange because values are clearly in L/min units.

DG-DEN-13460-2 22 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-11750-1 01 Mar 2022

This variable was very temporary. I deleted it.

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 28 Feb 2022

Can we prime lines in < 2 seconds?

HD-DEN-11750-2 02 Mar 2022

Done.

HD-DEN-8679-1 24 Jul 2021

The name of the function does not match with the actual name.

HD-DEN-8679-1 24 Jul 2021

Is it safe to stay in while loop until the hardware responds? I understand that you have a timeout but I thought we still should not do that.

HD-DEN-8679-1 24 Jul 2021

I recommend to explicitly name the input and output variables.

HD-DEN-8679-1 24 Jul 2021

Reverse the order of the condition.

HD-DEN-8679-1 24 Jul 2021

Why do you need an else here to zero the counter? Do you not need to 0 it anyways?

UI-DEN-8705-1 23 Jul 2021

from instead of form

HD-DEN-11098-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11114-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11114-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11114-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.