Comment Search

Defect Metrics

Statistics on the results
No defects in results

Search Criteria

Search for comments

Search Criteria

Project
Comment content
Review PermaId
After
Before
Comment Author
Search Type
Search Type:
Review State
Review State:
Metrics:
Metric Ranking
Metric Classification
Submit
  •  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5963-1 16 Apr 2021

This is an and. I changed the comment.
DG-DEN-5963-1 16 Apr 2021

Done.
DG-DEN-5963-1 16 Apr 2021

Done.
DG-DEN-5963-1 16 Apr 2021

I added a TODO on top to explain that this part will be addressed once the drain pump RPM can be read reliably. I added a build switch to ignore this part.
DG-DEN-5963-1 16 Apr 2021

I added a build switch to ignore this part.
DG-DEN-5963-1 16 Apr 2021

I added a build switch to ignore this part.
DG-DEN-5963-1 16 Apr 2021

I added a build switch to ignore this part.
DG-DEN-5963-1 16 Apr 2021

This is another way to be able to turn off the pump by just setting the RPM to 0.
DG-DEN-5963-1 16 Apr 2021

Done.
DG-DEN-5963-1 16 Apr 2021

Done.
DG-DEN-5963-1 15 Apr 2021

This should be a post-increment. Otherwise, it will never retry with MAX_ALLOWED_STATE_TRIALS = 1.
Apply to the rest of the file.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 15 Apr 2021

Recommend adding TRUE or FALSE to check explicitly. Apply to the rest of the file.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 15 Apr 2021

Should this be an OR (according to the comment)?
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 15 Apr 2021

Use SEC_PER_MIN to replace 60.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 15 Apr 2021

Align the define value (for most of the define section).
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 08 Apr 2021

Do we need to check for maximum limit here? What is the use of conductivity in this case?
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 14 Mar 2021

Not sure what's happening here. Restore this as it was.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 04 Jan 2021

Can you go ahead and move the rest of these to their respective module .h files and delete this header file from project?
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DG-DEN-5963-1 16 Apr 2021

RESOLVED in CODE WALKTHROUGH.
DIALIN-DEN-5963-2 16 Apr 2021

I moved it to hd_proxy.
DIALIN-DEN-5963-2 16 Apr 2021

RESOLVED.
DIALIN-DEN-5963-2 16 Apr 2021

This is an old code. Mode flush will be addressed in DIALIN-DEN-7568 which is mode flush.
DIALIN-DEN-5963-2 16 Apr 2021

Should this move to HD proxy as well?
DIALIN-DEN-5963-2 16 Apr 2021

RESOLVED.
HD-DEN-7395-1 15 Apr 2021

This should be compare to SELF_TEST_STATUS_PASSED now.
HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.
UI-DEN-8085-1 29 Apr 2021

Interesting.
Why it is a broadcast instead of a request/response?
Why does UI need a broadcast message while it will always be adjusted by UI?
DG-DEN-7802-1 23 Jul 2021

RESOLVED in CODE WALKTHROUGH.
UI-DEN-11980-1 16 Feb 2022

change #7 to #8
DG-DEN-7802-1 23 Jul 2021

RESOLVED in CODE WALKTHROUGH.
UI-DEN-11980-1 16 Feb 2022

please update the comment.
UI-DEN-11980-1 16 Feb 2022

Align with the reset.
HD-DEN-11980-1 16 Feb 2022

Function name is misleading. Sounds like Dialin is sending us new parameters, but it is only requesting current params be sent. I would change to something like testSendCurrentTreatmentParameters().
DG-DEN-5963-1 18 Apr 2021

I uncommented the code.
HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.