Done.
This is an and. I changed the comment.
I added a TODO on top to explain that this part will be addressed once the drain pump RPM can be read reliably. I added a build switch to ignore this part.
I added a build switch to ignore this part.
This is another way to be able to turn off the pump by just setting the RPM to 0.
This should be a post-increment. Otherwise, it will never retry with MAX_ALLOWED_STATE_TRIALS = 1. Apply to the rest of the file.
RESOLVED in CODE WALKTHROUGH.
Recommend adding TRUE or FALSE to check explicitly. Apply to the rest of the file.
Should this be an OR (according to the comment)?
Use SEC_PER_MIN to replace 60.
Align the define value (for most of the define section).
Do we need to check for maximum limit here? What is the use of conductivity in this case?
Not sure what's happening here. Restore this as it was.
Can you go ahead and move the rest of these to their respective module .h files and delete this header file from project?
I moved it to hd_proxy.
RESOLVED.
This is an old code. Mode flush will be addressed in DIALIN-DEN-7568 which is mode flush.
Should this move to HD proxy as well?
This should be compare to SELF_TEST_STATUS_PASSED now.
Interesting. Why it is a broadcast instead of a request/response? Why does UI need a broadcast message while it will always be adjusted by UI?
change #7 to #8
please update the comment.
Align with the reset.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
