•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5963-1 18 Apr 2021

Done.

DG-DEN-7802-1 23 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 18 Apr 2021

I uncommented the code.

DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-8705-1 23 Jul 2021

RESOLVED.

DG-DEN-7568-1 22 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 01 Mar 2022

Added ALARM_ID_INLET_WATER_HIGH_CONDUCTIVITY = 158, ///< Inlet water conductivity too high in AlarmDefs.h

HD-DEN-8679-1 29 Jul 2021

Added additional functions.

DG-DEN-9054-1 27 Jul 2021

I like to add a comment to right of system library includes explaining why they are needed (i.e. which math functions are you using in this module).

DG-DEN-11750-1 01 Mar 2022

Any reason why this is still a TODO?

HD-DEN-7347-1 25 Apr 2021

Is this function in charge of completely draining a reservoir? If yes, why should we provide a target parameter? Why not drain to 0 automatically?

HD-DEN-7347-1 25 Apr 2021

As per our design decision, reverse the second part of the and.

DG-DEN-12931-1 03 Aug 2022

Done.

DG-DEN-9054-1 26 Jul 2021

The GPIO register is shared (e.g. see fluid leak in above function). So I think we should have separate functions for each bit that we use in the GPIO register.
Also - why does the function name have the word Count in it?

DG-DEN-12931-1 03 Aug 2022

Each of these functions are used twice.

DG-DEN-9054-1 26 Jul 2021

Please restore the vector length test.

DG-DEN-9054-1 28 Jul 2021

These fill volumes will come from non-volatile memory. I also removed the TODOs.

HD-DEN-12931-2 03 Aug 2022

This can be reached in VC because it is not in a for loop.

HD-DEN-8679-1 27 Jul 2021

Done.

HD-DEN-8679-1 27 Jul 2021

Sent events only for changed settings.

DG-DEN-12931-1 04 Aug 2022

Will address in DEN-13460.

HD-DEN-12931-2 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 29 Jul 2021

Done.

HD-DEN-8679-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 26 Jul 2021

I think we set UF volume to zero in TreatmentParams mode, so this condition should not be necessary.

HD-DEN-8679-1 24 Jul 2021

Does the payload length does not match with the payload? In the payload, you have 1 U32 and 2 F32s so should not the length be U32 + 2 * F32?

DG-DEN-9054-1 30 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 26 Jul 2021

I think these @param descriptions could fit in one line for a cleaner look.

DIALIN-DEN-8856-1 30 Jul 2021

RESOLVED.

DG-DEN-9054-1 30 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8030-1 30 Jul 2021

RESOLVED.

HD-DEN-8679-1 30 Jul 2021

I moved this enum to DGDefs.h in HD-DEN-9054.

HD-DEN-9054-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 02 Aug 2021

Done.

HD-DEN-9054-1 30 Jul 2021

I moved it up so it will be run first with respect to the other exec functions. The epoch function is used to set an epoch value to the calibration records that failed but we set them the benign values.

HD-DEN-9054-1 30 Jul 2021

Done.

DG-DEN-9054-1 28 Jul 2021

The calibration structures are populated during POST. The initialization will be addressed in DEN-9480.

HD-DEN-9054-1 31 Jul 2021

HD does not have any caps.

DG-DEN-9054-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 12 Aug 2021

Change /* CIRC to /* GENE

DG-DEN-9054-1 03 Aug 2021

Done.

DG-DEN-9054-1 03 Aug 2021

Fixed the maxBufferLength variable.

HD-DEN-9054-1 04 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 03 Aug 2021

Unused parameter.

DG-DEN-9054-1 04 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 06 Aug 2021

Done.

UI-DEN-8705-1 06 Aug 2021
UI-DEN-8705-1 06 Aug 2021
HD-DEN-8679-1 05 Aug 2021

dgSubMode is missing.

HD-DEN-8534-1 11 Aug 2021

HD_fans