•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-8705-1 23 Jul 2021

does not (formal) instead of doesn't (informal)

UI-DEN-8705-1 23 Jul 2021

CAN Bus instead of can bus

DG-DEN-9054-1 27 Jul 2021

I don't see this being initialized in init function.

HD-DEN-9054-1 02 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9054-1 30 Jul 2021

Why was this moved?

UI-DEN-9411-1 12 Aug 2021

This is not the version of the code presented in the demo and now it reads the actual HWClock, not the system clock is being kept by the Linux system.
The first one was using the date which has been noted, and it has been changed to the current implementation.

DG-DEN-7802-1 12 Aug 2021

HD normally looks at this state to command fill or drain. We would want to wait until the flush lines to be done before drain or fill.

DG-DEN-7802-1 12 Aug 2021

The mode fill is calling this function to get the base weight before a fill (for load cell vs integrated flow check).
The large filter takes too long and mode fill sometimes get higher value if drain and fill happens too fast.

DG-DEN-7802-1 12 Aug 2021

To check for HD communication.

HD-DEN-8534-1 11 Aug 2021

It should be HD fans.

HD-DEN-8886-1 12 Aug 2021

Are we planning to have #defines instead of the numbers?

DG-DEN-7802-1 12 Aug 2021

Change to #ifdef?

HD-DEN-11114-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11114-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 04 Jan 2022

Done.

DG-DEN-11114-1 04 Jan 2022

Done.

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 04 Jan 2022

I will implement this in DEN-11750.

DG-DEN-11114-1 04 Jan 2022

Add blank line between declarations and code.

DG-DEN-11114-1 04 Jan 2022

Can we remove these now? Update message list and UI unhandled message conf file.

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 04 Jan 2022

Why is this code commented out?

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11250-1 31 Jan 2022

Done.

HD-DEN-11250-1 28 Jan 2022

This name and comment suggest that threshold is absolute (literally > 0.5V), but threshold is actually a baseline voltage (taken after seek) + 0.5V.

DG-DEN-5963-1 19 Apr 2021

Yes, they only have one temperature sensor per board.

DG-DEN-7568-1 19 Apr 2021

Done.

DG-DEN-7568-1 19 Apr 2021

Done.

HD-DEN-8679-1 27 Jul 2021

Fixed.

DG-DEN-7568-1 19 Apr 2021

Done.

HD-DEN-8679-1 27 Jul 2021

Done.

DG-DEN-7568-1 19 Apr 2021

Inputs are data looked at in this function (e.g. in an if statement). Outputs are data that are changed in this function.

DG-DEN-9054-1 28 Jul 2021

This structure was transferred DGDefs.h

DG-DEN-7568-1 19 Apr 2021

Done.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 28 Jul 2021

This is fixed in the latest commit.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 29 Jul 2021

Done.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8856-1 29 Jul 2021

Removed the return of CAN frame list.

DIALIN-DEN-7395-1 19 Apr 2021

Addressed in Class definition section and _init_(...)

HD-DEN-8679-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

SRVC-DEN-7335-1 21 Apr 2021

Would the end-user know the type of parameter to be sent, or does it make sense to make that choice for them automatically? Think that not all end-users are SW savvy (manufacturing, service, etc.)

DG-DEN-7568-1 22 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7568-1 23 Apr 2021

Done.

HD-DEN-7347-1 25 Apr 2021

Do we need a fault here?