•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 27 Jul 2021

Set UF volume initially to 0 and removed this variable and related function.

DG-DEN-5963-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 08 Apr 2021

Why not using a union? Much more optimized for memory-limited devices.

HD-DEN-11750-2 03 Mar 2022

Done.

DG-DEN-11750-1 24 Feb 2022

Do we need an if for an always true condition? does this branch statement need to be uncommented?

DIALIN-DEN-7395-1 21 Apr 2021

RESOLVED.

UI-BUG-S62-1 18 Jan 2022

Isn't is safer to have a break at the end of each case?

DIALIN-DEN-7792-1 21 Apr 2021

RESOLVED.

DG-DEN-7568-1 22 Apr 2021

Done.

DG-DEN-9054-1 29 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7347-1 25 Apr 2021

This function needs a header.

DG-DEN-11928-1 23 Mar 2022

Initialized badFillState where it is declared in the private data section.

DG-DEN-9054-1 30 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 30 Jul 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9054-1 29 Jul 2021

Param name is not matched.

HD-DEN-9054-1 02 Aug 2021

Done.

HD-DEN-8679-1 05 Aug 2021

This header is no longer needed.

DG-DEN-11928-1 23 Mar 2022

Sean is OK with current implementation.

UI-DEN-9411-1 12 Aug 2021

It is a red line and has already been removed.

DG-DEN-11114-1 04 Jan 2022

Done.

UI-DEN-9411-1 12 Aug 2021

RESOLVED.

UI-DEN-9411-1 12 Aug 2021

Comment doesn't match code.

UI-DEN-9411-1 12 Aug 2021

Comment doesn't match code.

DG-DEN-11928-1 23 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8534-1 12 Aug 2021

Done. I always try to keep them alphabetized.

HD-DEN-8534-1 12 Aug 2021

We would want target RPM, RPM from tach, and PWM published.

UI-DEN-9411-1 12 Aug 2021

Missing brief.

DG-DEN-7802-1 12 Aug 2021

Is there a problem with this alarm? Need a TODO?

DG-DEN-11114-1 04 Jan 2022

Done.

DG-DEN-11928-1 23 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 23 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 05 Jan 2022

The heaters sensors are not used to monitor the internal temperature of the heaters. I added a build switch.

DG-DEN-11114-1 04 Jan 2022

I prefer to declare variables at top of scope (after '{' above).

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 04 Jan 2022

Add doxygen comments.

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11114-1 05 Jan 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-11928-1 31 Mar 2022

Done.

DG-DEN-11114-1 05 Jan 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-12224-16 30 Mar 2022

Do we need to keep this define?

HD-DEN-11250-1 31 Jan 2022

Renamed forceAtStartOfPriming to forceAtEndOfSeek.

HD-DEN-11250-1 28 Jan 2022

These min/max bolus rates are obsolete now, right?

UI-BUG-S62-1 26 Jan 2022

When will we do this?

DG-DEN-7568-1 19 Apr 2021

Done.

DIALIN-DEN-11980-1 16 Feb 2022

Why is I capitalized?

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8679-1 27 Jul 2021

Removed.

HD-DEN-7395-1 19 Apr 2021

RESOLVED in CODE WALKTHROUGH.