RESOLVED in CODE WALKTHROUGH.
Preferred architecture is to just set a request flag here and then let your state machine see the flag and change the state and command the FPGA action the next time it executes.
This message is requested by UI. UI wants to keep it consistent with other request message, in case there is reject reason in the future.
This message has been defined with 5xF32 parameters.
Set UF volume initially to 0 and removed this variable and related function.
Why not using a union? Much more optimized for memory-limited devices.
Done.
Do we need an if for an always true condition? does this branch statement need to be uncommented?
RESOLVED.
Isn't is safer to have a break at the end of each case?
This function needs a header.
Initialized badFillState where it is declared in the private data section.
Param name is not matched.
This header is no longer needed.
Sean is OK with current implementation.
It is a red line and has already been removed.
Comment doesn't match code.
Done. I always try to keep them alphabetized.
We would want target RPM, RPM from tach, and PWM published.
Missing brief.
Is there a problem with this alarm? Need a TODO?
The heaters sensors are not used to monitor the internal temperature of the heaters. I added a build switch.
I prefer to declare variables at top of scope (after '{' above).
Add doxygen comments.
RESOLVED IN CODE WALKTHROUGH
Do we need to keep this define?
Renamed forceAtStartOfPriming to forceAtEndOfSeek.
These min/max bolus rates are obsolete now, right?
When will we do this?
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
