RESOLVED.
Yes, if they are initialized in init() which they should be, they don't need to be initialized here. This puts this static variables in the uninitialized section of the memory.
Done.
Why is vScript not a const?
Recommend changing > to >= and then removing the - 1.
Sean Nash please respond,.
Put space between if and (.
Uncommented requestNewOperationMode( )
Yes, I think we should do that
Too low should be < 100 (check w/ Systems). There should be 2 too high alarms: 1) warning (>=2000) and 2) alarm (>=2200).
Do we need to set RO pump rate here before we move on to produce/delivery dialysate?
Added requestNewOperationMode( DG_MODE_GENE );
Removed else requestNewOperationMode( DG_MODE_GENE );
Why VAlarmStatus is added?
Set isThisFirstFill = FALSE per comment.
Any reason why this declaration isn't at top of function?
RESOLVED in CODE WALKTHROUGH.
Remove blank line.
There are 2 functions in this module with this name.
I think there should be a #ifndef RELEASE around these build switches.
Removed line //requestNewOperationMode( DG_MODE_GENE );
Do we need to keep this alarm?
or this alarm?
Stagger?
Please update the documentation.
Will be addressed in in DIAL-171.
Please change the byte order of struct.unpack
This will be addressed in DEN-12931.
Updated
Alarm is not a fault. Updated clear immediate to false in AlarmDefs.h in Staging.
This has the rank of a fault and I think it should be an HD fault - so set the T/F properties same as the alarm above (FPGA clock speed check).
Is fabs() appropriate here?
Why are there 2 of these?
This #define should be at the top of the file.
http://dvm-linux02:8060/cru/#UI-DEN-12716-2CFR-30978 in PostTreatmentReview.qml@40
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
