•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-11980-1 16 Feb 2022

Please from the equal sign ( = )

HD-DEN-7395-1 13 Apr 2021

The clearAlarmCondition() function will check if the alarm is active or not and only clears if the alarm has been raised.

DG-DEN-5963-1 14 Apr 2021

This variable has been deleted.

HD-DEN-8030-1 24 Jun 2021

DG will reject staring any of the disinfects if it is not in the right mode.

DIALIN-DEN-7792-1 14 Apr 2021

This message ID should be MSG_ID_UI_INITIATE_TREATMENT_REQUEST (0x38).

DG-DEN-5963-1 13 Apr 2021

Done.

HD-DEN-7395-1 13 Apr 2021

Recommend typecasting bloodLeakState to (U32)bloodLeakState. Outside of this driver the enums are only U32s until they are converted to states again in Dialin.

HD-DEN-8030-1 25 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 23 Jun 2021

Why removed?

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-10602-2 15 Dec 2021

RESOLVED

DIALIN-DEN-10602-2 15 Dec 2021

Thanks for the fix.
I fixed the other functions as well.

DIALIN-DEN-11980-1 17 Feb 2022

Fixed. Thanks!

DIALIN-DEN-11980-1 17 Feb 2022

Please update the BloodFlow and DialysateFlow in the hd_simulator as well.

DG-DEN-13834-1 17 Oct 2022

Should be 3.0F

LEAHI-DD-FIRMWARE-LDT-1473-1 11 Feb 2026

Updated.

UI-DEN-10205-1 22 Dec 2021

it has been fixed on the merge conflict.
748e088be863e08a1f8d12ff895c2525cd891e31

HD-DEN-14001-1 17 Oct 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-10602-1 17 Dec 2021

Some functions and variables in this file use PatientID instead of PtientID, was this spelling intentional?

HD-DEN-11114-1 03 Jan 2022

Done.

UI-DEN-10205-1 22 Dec 2021

Ummm,
Haven't ever thought about it, this is a very good point.
Will look into it, since the actual friend class will not ever be available in the production code.

UI-DEN-10205-1 21 Dec 2021

A very important concept.
I refer you to the Qt connection concept for detailed information.
https://doc.qt.io/qt-5/signalsandslots.html
The idea is, the connect has 4 parameter
1 - Signal owner object
2 - Signal member function
3 - Slot owner object
4 - Slot member function
When the signal owner is emit-ed, the slot owner will call its slot by the passed parameter from the signal function.
It is very important to use the connection concept, in opposed to the simple call, in case the signal owner and slot owner, objects, are in two different threads.
It is the Qt way of thread-safe calling.

DIALIN-DEN-11750-1 23 Feb 2022

Agreed. I will clean them up gradually. Removed the commented code.

HD-DEN-11098-1 30 Dec 2021

Done.

DIALIN-DEN-11750-1 23 Feb 2022

This script is in the tests folder. The tests folder is not controlled in the way the Dialin files are controlled so I might go back and forth in between different tests. This is not affecting any of the Dialin features.

HD-DEN-11098-1 30 Dec 2021

Can we please use available alarm IDs above before adding a new one?

HD-DEN-11114-1 30 Dec 2021

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

DIALIN-DEN-11750-1 23 Feb 2022

Fixed it.

DIALIN-DEN-11750-1 22 Feb 2022

Please remove comments if they are no longer applicable to the test.

DIALIN-DEN-11750-1 23 Feb 2022

Done.

DIALIN-DEN-11750-1 23 Feb 2022

RESOLVED.

DG-DEN-11750-1 25 Feb 2022

Add #ifndef RELEASE around these definitions and all other build switch related code.

HD-DEN-11750-2 24 Feb 2022

Do we want to keep this commented out defs?

DG-DEN-11750-1 25 Feb 2022

Are these really common? Can they be moved to sys_selftest.c?

DG-DEN-11750-1 25 Feb 2022

Should be #ifndef RELEASE around this structure.

DG-DEN-11750-1 25 Feb 2022

Add #ifndef RELEASE around this enum.

DG-DEN-11750-1 25 Feb 2022

This was commented for testing. I un-commented it.

DG-DEN-11750-1 25 Feb 2022

Good catch, thanks.

DG-DEN-11750-1 24 Feb 2022

Does this need to be memset when we can initialize it with 0'd values above? (line 92)

HD-DEN-11750-2 24 Feb 2022

Should 300 be a magic number?

DG-DEN-13460-2 22 Sep 2022

RESOLVED IN CODE WALKTHROUGH

UI-DEN-11980-1 16 Feb 2022

RESOLVED.

HD-DEN-14000-1 14 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8030-1 24 Jun 2021

I added the rest of the code.

HD-DEN-8030-1 21 Jun 2021

Do we need DG to be in standby mode also?

UI-DEN-10205-1 22 Dec 2021

The vScript parameter will accept the arguments which will be changed in the function, so has been defined as a reference with no const.

UI-DEN-11980-1 16 Feb 2022

RESOLVED.

DIALIN-DEN-8514-2 24 Jun 2021

Remove spaces around "=" sign.

DIALIN-DEN-10602-2 15 Dec 2021

That "origin" is intentional.
I actually tried to find a word with a correct meaning with the same character length as Target, Actual, Origin. Since this one is not showing up on any scrip or file other than the code, that is fine.

LEAHI-APPLICATION-LDT-1616-1 23 Sep 2025

RESOLVED.