•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5963-1 14 Apr 2021

This variable has been deleted.

HD-DEN-8030-1 24 Jun 2021

Done

DG-DEN-5963-1 14 Apr 2021

I renamed the function. This part has been changed and the current state will not be overridden.

HD-DEN-11098-1 02 Dec 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 13 Apr 2021

I would say this function requests that the blood leak detector be zeroed (and self-tested). Zero does not happen right here in this function.

DIALIN-DEN-7792-1 14 Apr 2021

Mismatch filename.

HD-DEN-11980-1 17 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11114-1 02 Dec 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 16 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11980-1 17 Feb 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-10602-2 15 Dec 2021

According to PRS 178:
These are actually:

  • "Final Target Ultrafiltration Volume"
  • "Final Target Ultrafiltration Rate"
    for simplicity, the "Final" portion has been removed and only the "Target" is used since all SW knows them as "Target" only.
HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-11980-1 17 Feb 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11098-1 13 Dec 2021

Done

DIALIN-DEN-11750-1 23 Feb 2022

RESOLVED.

DIALIN-DEN-10602-2 15 Dec 2021

RESOLVED

DIALIN-DEN-10602-2 15 Dec 2021

RESOLVED

HD-DEN-11098-1 13 Dec 2021

Yes, we could use a single variable as the start time in all the pre-treatment states

HD-DEN-11114-1 03 Jan 2022

Yes, if you add "alarm no alarm" it will not be checked.

HD-DEN-10602-1 16 Dec 2021

After talking with Hung,
This change is currently on his feature branch and should not be changed in here,
later which codes are merged it will be resolved in case of conflict.

HD-DEN-11098-1 03 Jan 2022

Done.

UI-DEN-10205-1 21 Dec 2021

Sometimes it's only the FS properties (changed to executable) of the file that git takes it as a change.

DIALIN-DEN-11750-1 23 Feb 2022

RESOLVED.

UI-DEN-10602-1 13 Dec 2021

Needs function header?

DIALIN-DEN-11750-1 23 Feb 2022

RESOLVED.

DIALIN-DEN-11750-1 22 Feb 2022

Is there a specific reason why we create our Observer object after the request has been called?

DIALIN-DEN-11750-1 22 Feb 2022

Please rename this observer class to something more specific. Ex: NVUtilsObserver. Generalized naming may cause problems with advanced usage of the API.

HD-DEN-11098-1 03 Jan 2022

Done.

DIALIN-DEN-11750-1 23 Feb 2022

RESOLVED.

HD-DEN-11114-1 30 Dec 2021

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buffer to populate - otherwise it will overwrite memory.

DG-DEN-11750-1 25 Feb 2022

Done.

DG-DEN-11750-1 25 Feb 2022

This macro has been removed.

DG-DEN-11750-1 25 Feb 2022

Done.

HD-DEN-11750-2 26 Feb 2022

Yes. We might go back to it.

HD-DEN-11750-2 26 Feb 2022

Good point, I updated it.

HD-DEN-11750-2 24 Feb 2022

Shouldn't this include be in TaskGeneral.c?

DG-DEN-11750-1 25 Feb 2022

Looks like this needs to be addressed.

HD-DEN-11750-2 24 Feb 2022

There are no changes in this file and its not a new file.

DG-DEN-11750-1 22 Feb 2022

We should probably keep the = 0;

DG-DEN-11928-1 28 Feb 2022

Array name and comment should indicate this is for flushing bubbles after priming concentrate lines.

DG-DEN-11928-1 28 Feb 2022

These are both maximums. Should be something like MAX_INPUT_WATER_TEMP_ALARM and MAX_INPUT_WATER_TEMP_WARNING.

DG-DEN-11928-1 28 Feb 2022

These conductivity thresholds should probably come from DG calibration record. Talk to Dara.

DG-DEN-13460-2 22 Sep 2022

RESOLVED IN CODE WALKTHROUGH

UI-DEN-11980-1 16 Feb 2022

RESOLVED.

UI-DEN-10205-1 21 Dec 2021

That is a very good question.
As much as possible we have to put the #includes in the CPP files and not the header.
The #include in the header will always be imported even if you don't compile the code (only CPP is compiled in c, not the header) as opposed to just including when needed to compile in CPP.
This also helps the compiler to optimize the code better and faster to compile.
you only need to put it in the header if you inherit from the class defined in the class included or you have a variable/parameter defined of that file in the header.

HD-DEN-14000-1 14 Oct 2022

RESOLVED IN CODE WALKTHROUGH

UI-DEN-10205-1 21 Dec 2021

RESOLVED

DG-DEN-5963-1 13 Apr 2021

Done.

DG-DEN-8030-1 21 Jun 2021

This a matter of trying the temperature sensors more than once before we start the cycle. Making the wait time longer will not necessarily help the sensors to read within the range.

UI-DEN-10205-1 21 Dec 2021

This file was changed but no changes are highlighted, any idea what happened?