•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5963-1 13 Apr 2021

[~qnguyen] Could you please address?

DG-DEN-13460-2 22 Sep 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7044-1 13 Apr 2021

RESOLVED

DG-DEN-5963-1 14 Apr 2021

This enum has been deleted.

HD-DEN-8030-1 01 Jul 2021

Done

DG-DEN-5963-1 14 Apr 2021

I changed the functions.

DG-DEN-5963-1 14 Apr 2021

Each condition should be put in a parenthesis ().

DG-DEN-5963-1 13 Apr 2021

Both false and true cases are needed (for clear and trigger alarm). Recommend turning the if statement into a variable and pass in as parameter.

DIALIN-DEN-8514-2 02 Jul 2021

RESOLVED

HD-DEN-8030-1 04 Jul 2021

I had a similar function for this.

HD-DEN-8030-1 05 Jul 2021

Done

HD-DEN-8030-1 07 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8030-1 28 Jun 2021

Add blank lines after declarations.

HD-DEN-8030-1 02 Jul 2021

Should we rename this message ID? The name does not seems to match the broadcast function.

HD-DEN-8030-1 07 Jul 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-10602-1 16 Dec 2021

Late breaking news, the HD_PRE_TREATMENT_PRIME_STATE_T has changed.
The correct order of the items in enum type of the pre-treatment states are listed below:

HD_PRIME_START_STATE = 0, ///< Prime start state
HD_PRIME_WAIT_FOR_USER_START_STATE, ///< Wait for user to start prime state
HD_PRIME_SALINE_SETUP_STATE, ///< Saline setup state
HD_PRIME_SALINE_PURGE_AIR_STATE, ///< Saline purge air state
HD_PRIME_SALINE_CIRC_BLOOD_CIRCUIT_STATE, ///< Circulate blood circuit state
HD_PRIME_RESERVOIR_ONE_FILL_COMPLETE_STATE, ///< Wait for reservoir 1 fill complete
HD_PRIME_DIALYSATE_DIALYZER_STATE, ///< Dialysate dialyzer fluid path state
HD_PRIME_SALINE_DIALYZER_SETUP_STATE, ///< Saline dialyzer setup state
HD_PRIME_SALINE_DIALYZER_STATE, ///< Saline dialyzer fluid path state
HD_PRIME_RESERVOIR_TWO_FILL_COMPLETE_STATE, ///< Wait for reservoir 2 fill complete
HD_PRIME_DIALYSATE_BYPASS_STATE, ///< Dialysate bypass fluid path state
HD_PRIME_WET_SELF_TESTS_STATE, ///< Perform wet self-tests after priming complete
HD_PRIME_PAUSE, ///< Prime pause state, waits to be resumed
HD_PRIME_COMPLETE, ///< Prime complete state
NUM_OF_HD_PRIME_STATES ///< Number of prime sub-mode states

DIALIN-DEN-8856-1 19 Jul 2021

Done.

DIALIN-DEN-8856-1 19 Jul 2021

RESOLVED.

UI-DEN-8705-1 20 Jul 2021

Removed

UI-DEN-8705-1 20 Jul 2021

Removed

DG-DEN-7802-1 21 Jul 2021

We have to flush the filter flush before user can request to sample water.

DIALIN-DEN-8856-1 21 Jul 2021

These are no definitions of these class inside alarm_defs.py yet. I think this means PRS definitions rather than pressure.
Behrouz NematiPour Should these definitions be moved to another file?

DG-DEN-7802-1 20 Jul 2021

Why not alarm?

DG-DEN-7802-1 01 Jul 2021

I believe this will eventually be a constant in the non-volatile calibration record. So will have a getter function in NV-Data module for this value.

DG-DEN-7802-1 21 Jul 2021

Input: startSampleWaterRequest, endSampleWaterRequest.

DG-DEN-7802-1 21 Jul 2021

Output: startSampleWaterRequest, endSampleWaterRequest, waterSampleStartTime.

DG-DEN-7802-1 21 Jul 2021

Why there is a endSampleWaterRequest in this state? We should never get here if sample water request is in place.
Also, if this an endSampleWaterRequest here, VSP should be closed.

DG-DEN-7802-1 21 Jul 2021

Should we turn on VSP?

UI-DEN-8705-1 09 Jul 2021

Remove extra line.

DIALIN-DEN-8856-1 20 Jul 2021

What does it mean to return two things: frames and message?

DIALIN-DEN-8856-1 20 Jul 2021

Aren't these alarm enums duplicates of the ones in alarm_defs.py? Also, file name suggests these are pressure related definitions - so why are alarm definitions in here?

DG-DEN-7802-1 20 Jul 2021

I think this is pretty clear, but for consistency, add a comment for this condition.

HD-DEN-11098-1 03 Jan 2022

Dara, did you add this alarm?

UI-DEN-10205-1 03 Jan 2022

Sorry I meant parameters not arguments.

UI-DEN-10205-1 03 Jan 2022

In the firmware we add a TODO to be able to grep them easily and make sure we do not forget any commented code.
RESOLVED.

HD-DEN-11114-1 04 Jan 2022

Done.

HD-DEN-11098-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11098-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11098-1 04 Jan 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11114-1 04 Jan 2022

Done.

DG-DEN-11114-1 05 Jan 2022

The heaters sensors are not used to monitor the internal temperature of the heaters. I added a build switch.

DG-DEN-11114-1 05 Jan 2022

Done.

DG-DEN-11114-1 04 Jan 2022

Let's just solve this now instead of commenting it out.

DIALIN-DEN-11250-1 16 Feb 2022

Should this be log in to hd?

UI-DEN-11980-1 16 Feb 2022

remove this comment since it was there to separate the two models.

DG-DEN-5963-1 13 Apr 2021

Dara Navaei Please refactor the name to cp1CurrentSetSpeed and cp2CurrentSetSpeed. Thank you!

DG-DEN-11750-1 26 Feb 2022

Yes that is true. One is specifically looking at the HD software config and the other is checking the DG software config. I can have one function that covers both but it has to have #ifdef for for HD and DG.

DG-DEN-5963-1 14 Apr 2021

This enum has been deleted.

HD-DEN-11250-1 01 Feb 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 14 Apr 2021

I removed 2. If faster publish time is needed, it should be overridden via Dialin.