It could be since both of the code reviews are for the S63 changes. Probably the same commit has been added.
Lines above are formatted to align terms of equation. This line is not.
To make sure the addition is done first, should you put ( width + minimum ) ?
Addressed.
RESOLVED in CODE WALKTHROUGH.
Brief looks wrong.
This looks wrong too.
Done.
Remove extra blank line.
First sizeof() should have U32 (same as above).
RESOLVED.
Common has an enumeration (OPN_CLS_STATE_T) that is similar to this. Suggest using from common.
This can fit in one line.
Updated.
That is the function signature and doesn't have to have any parameter defined if it is not being used and no argument is passing to it. This way we don't need to use the Q_UNUSED(vData); anymore for parameters not being used.
Remove unused defines
All these structures need doxygen comments.
Removed. This alarm is removed in branch DEN-8886.
Yes, there might be other release issues. We have not built release in a long time but we can resolve them once we decided to have a release build.
I removed the comment.
I would like to keep these for now until the heaters sensors are completely out.
There should be 2 blank lines above and below the TEST SUPPORT FUNCTIONS banner below.
We don't need this here. startHeparinBolus() was moved to handleWetSeltTestStartState(void) function. F32 bolusVol = getTreatmentParameterF32( TREATMENT_PARAM_HEPARIN_BOLUS_VOLUME ); setDialInPumpTargetFlowRate( DIP_FLOW_RATE_SETUP_ML_MIN, MOTOR_DIR_FORWARD, PUMP_CONTROL_MODE_OPEN_LOOP ); fmdIntegratedVolume = 0.0; if ( ( bolusVol > 0.0 ) && ( getSyringePumpVolumeDelivered() < bolusVol ) )
This can be uninitialized. It is initialized in the init function below.
Done. Called checkForPrimeOcclusion(); with no parameters.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
