Need to address TODOs. Have we assessed what an appropriate max delta should be? Alarm should be cleared if it is recoverable (not a fault) and not cleared immediately (see alarm properties).
Better name is reservoir use cycle steady sample points (during treatment, but we're in Dialysis.c here so treatment can be inferred).
Remove blank line.
Probably because assuming that the list of ACK_NOT_REQUIRED messages (at least at the time of implementation) was a shorter list.
Fixed. Thanks!
Yes, at bottom of exec function above.
What is the point in having these locals? Why not just use the concentratePumps fields directly?
Keep this blank line.
Use explicit condition ( TRUE == resetStateTimer ).
I don't see resetStateTimer being used (unless commented out code is coming back). Also, it is not in function header.
Modified names
Fixed. Good catch. started with boolean, but changed to enum.
Removed.
Separate assignments or at least put all in same line.
Why commented out? Remove if no longer needed. If coming back, use explicit condition ( TRUE == resetStateTimer ).
Can we remove this now?
This looks like it allows flows > maximum now. What is the intent here?
Add resetStateTimer @param.
Why commented out? Remove if no longer needed.
Removed it.
You can just use 0.0F here.
Define disable (even if not used) so it is clear which bit position controls enable/disable.
Fix alignment.
RESOLVED in CODE WALKTHROUGH.
RESOLVED.
Comment doesn't match code.
What about functions for 1) getting zero status, 2) setting sensor config (normal, self-test, zero)?
Yes, I have a TODO to finish them off in DEN-12224.
Addressed.
Add TODO to remove later.
Removed blank line
RESOLVED in CODE WALKTHROUGH
It has been removed. We should reserve our Alarm System mostly for critical HW issues during treatment.
This was commented out for testing. It is back on.
Done.
Dereferencing which parameter here? (sorry I have never seen this in the past)
Only two places call this function. Should we inline and remove this function?
Revert the deleted comment.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
