Comment Search

Done.

Added.

Done.

This struct needs doxygen comment on individual member.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Updated.

I added the type information to the functions that I recently added.

Need to put the type information here

RESOLVED.

Looks like this needs to be updated

Remove extra lines.

Remove extra line.

Could you please explain why do you need this flag?

Fixed.

Please modify the signal's name so it always has the Clicked/Pressed/... at the end.
Please apply for every other occurance.

Generally, when writing conditions involving a BOOL, try to form condition to use TRUE or FALSE depending on whichever will favor the safer path (e.g. if a bug or stack/array overflow corrupted the BOOL to a value like 0x12345678, this condition would still pass).
So in this condition, we are deciding whether dialysate can be delivered to the reservoir. We would like to err on the side of not delivering to the reservoir (safer state). So we should form the condition in a way that conductivity and temperature ranges being good must be TRUE (1) in order to deliver dialysate to the reservoir. Any other value would result in coming out of dialysate delivery state which is the safer thing to do.

keep one line empty on top of the // HD Data Messages

I think VDateTime.h is less safe in this case. It should be updated to match

if (_process.state() != QProcess::NotRunning) { return; }

to prevent re-starting the process when its already in the "Starting" state as well as the "Running" state.

    enum ProcessState {
        NotRunning,
        Starting,
        Running
    }; 

When will it be implemented?

updated