•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-9906-1 28 Oct 2021

Remove extra blank line.

UI-DEN-10206-1 01 Nov 2021

Function needs header.

RO-LDT-1242-1 03 Sep 2025

fixed thanks!

DIALIN-DEN-8055-1 29 Apr 2021

Recommend converting to use message field positions and remove local defines.

HD-DEN-7605-2 03 May 2021

Same as above.

HD-DEN-8886-1 13 Aug 2021

Fixed.

HD-DEN-7605-2 04 May 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-8085-1 29 Apr 2021

alarmVolumeTemp is the temporary volume being selected by the user while they are adjusting.
alarmVolume is the kept alarm volume when the user exits the alarm volume screen.
alarmVolume is set to alarmVolumeTemp only if the user hits confirm
Upon confirm, alarmVolume is updated to be the same value as alarmVolumeTemp and is then sent down to the HD.
Upon back / cancel, alarmVolume is left unchanged and is sent down to the HD to undo the temporary setting
FW does not expose a play alarm volume without set message so we have to set the volume each time it is played for the user while they are adjusting.

HD-DEN-11750-2 03 Mar 2022

RESOVLED IN CODE WALKTHROUGH.

HD-DEN-8534-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7752-1 04 May 2021

Now updated to just variables since they are not used in qml

DG-DEN-7802-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-5 02 Dec 2022

Fixed. Thanks!

UI-DEN-9626-1 21 Sep 2021

updated.

UI-DEN-9626-1 21 Sep 2021

This was not a bug,
It was a change request from Sarina to remove the Rinseback Aditional 5 min counter.
I kept it in case we may need it later.

HD-DEN-7605-2 03 May 2021

Dara to refactor the POST test for RTC vs. processor timer so that we expect 1000 ms of processor time after RTC second changes. He and I have discussed this needed change.

UI-DEN-9626-1 24 Sep 2021

RESOLVED.

DIALIN-DEN-8055-1 04 May 2021

These are 1 and 2 byte fields, so cannot use the generic 4-byte field names.

DIALIN-DEN-8055-1 05 May 2021

Done

DG-DEN-9906-1 25 Oct 2021

Fixed

DIALIN-DEN-7605-1 06 May 2021

Done.

DIALIN-DEN-7605-1 06 May 2021

Fixed.

UI-DEN-7752-1 06 May 2021

RESOLVED

UI-DEN-7752-1 29 Apr 2021

For the properties, we don't use 'm' as a prefix and only start the name with no capital letter.

DIALIN-DEN-9906-1 28 Oct 2021

Fixed

HD-DEN-10153-1 26 Oct 2021

Fixed

HD-DEN-7860-1 12 May 2021

Compiler gives warnings with U32 casting, left code as is.

HD-DEN-7860-1 11 May 2021

These declarations seem odd. Please re-check.

HD-DEN-7860-1 11 May 2021

Same comment as above.

HD-DEN-7860-1 11 May 2021

Re-word comment.

HD-DEN-7860-1 11 May 2021

Incorrect casting type.

HD-DEN-7605-2 07 May 2021

Need to remove this comment.

HD-DEN-9906-1 27 Oct 2021

FALSE is simply zero and TRUE is one. In case a boolean is somehow corrupted to something other than 1 or 0, I like to err on the side of safety.
So the way I have it now, if isBloodPumpRunning() gets corrupted to > 1, it will consider that the pump is not running which is the safer thing to do.

HD-DEN-9906-1 27 Oct 2021

If using a "==" comparison operator, I like to put the literal first so that the compiler will error if I accidentally use "=" instead.
Otherwise, I like to put the literal last because it reads better.

DIALIN-DEN-9906-1 28 Oct 2021

Fixed

HD-DEN-9906-1 27 Oct 2021

Fixed.

HD-DEN-9906-1 26 Oct 2021

Add file header

HD-DEN-9906-1 27 Oct 2021

RESOLVED IN CODE WALKTHROUGH

DG-DEN-9906-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9906-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9906-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-10153-1 26 Oct 2021

If no params, put void.

HD-DEN-10153-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-9906-1 28 Oct 2021

RESOLVED.

HD-DEN-9906-1 26 Oct 2021

This file is missing a file header

UI-DEN-10206-1 01 Nov 2021

Should we add a TODO here so we don't forget?

UI-DEN-10206-1 01 Nov 2021

There is no todo or fix for this.
It is a hint for developers to be careful when using this in debugging since it affects the performance.
Added more clarification.

UI-DEN-10206-1 01 Nov 2021

updated.