What is Temp mean, if it means default please put def, and if it is the step please put Step. Or if it is the previous value you kept for back to be sent back to HD, Please use prev/previous.
Good point, I could not find this function in the simulator, and it means it is a very old function implemented when we were doing Automated Unit Tests. The return value may have been used in the Unit test since this is the message (create treatment parameters response) which has bool for each param and the return could be the final result (and of all single ones). I agree we decided but since this code has not been touched since then and that decision has been made after that function it doesn't have that in the definition. I would rather not touch it, since it wasn't part of this task modification (Safety Volume) and I don't know what will break after the modification.
1) What is this sleep for? 2) How did you come up with its value? (I assume this is in seconds?) 3) Is this value consistent among all 4 prototypes and the development boards that we have?
I agree we want to send the two status enums as a U32 over the CAN. I think it's better to assign w/ cast the two status to local U32s before memcpy into payload. That way, memcpy is given 4 bytes to copy. As is, I worry compiler will only have 1 or 2 bytes for the enum passed into the function and we're forcing memcpy to copy 4 bytes - could corrupt the upper bytes of the two status fields in the message payload.
