•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-9626-1 20 Sep 2021

RESOLVED.

UI-DEN-9626-1 20 Sep 2021

RESOLVED.

DIALIN-DEN-9626-1 21 Sep 2021

RESOLVED.

UI-DEN-9626-1 21 Sep 2021

In UI we have multiple types of TODOs.
DEBUG, FIXME, WARNING, NOTE, TODO

UI-DEN-9626-1 21 Sep 2021

RESOLVED.

UI-DEN-9626-1 24 Sep 2021

RESOLVED.

UI-DEN-10424-1 11 Oct 2021

Since we have more than one message which is using the dynamic structure now we have a "MAbstractDynamic" model (link bellow) as the parent and these codes have been moved to the parent and all the 3 messages are using the same structure.
http://dvm-linux02:8060/cru/#UI-DEN-10424-1CFR-27600

HD-DEN-10153-1 26 Oct 2021

Fixed

HD-DEN-9906-1 26 Oct 2021

Add file header

HD-DEN-9906-1 26 Oct 2021

Shouldn't be?

( FALSE == isBloodPumpRunning() )
HD-DEN-9906-1 27 Oct 2021

RESOLVED IN CODE WALKTHROUGH

DG-DEN-9906-1 21 Oct 2021

Move this up before second pass of FPGA executive call.

DG-DEN-9906-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9906-1 21 Oct 2021

Move this up with other monitor inits (e.g. initPressures).

DG-DEN-7802-1 28 Apr 2021

The if should be < and the else if should be >= otherwise there is double-dipping in case the value equals.

DG-DEN-11750-1 22 Feb 2022

All the new timer counters no longer are initialized to 0. I understand that they get set in their respective init()'s to the timer counter, but was this intentional?

HD-DEN-8886-1 13 Aug 2021

Fixed.

DG-DEN-11750-1 22 Feb 2022

If the DG is broadcasting these raw values, shouldn't Dialin be sync'd as well to handle these new fields?

RO-LDT-1242-1 03 Sep 2025

fixed thanks!

UI-DEN-7752-1 11 May 2021

RESOLVED

HD-DEN-8886-1 19 Aug 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-8308-1 13 May 2021

RESOLVED

HD-DEN-7605-2 04 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 03 May 2021

Change comment from 11 ml to 13 ml if 13 ml is the current placeholder.

DIALIN-DEN-9633-1 27 Aug 2021

RESOLVED.

HD-DEN-7605-2 04 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 04 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 03 May 2021

These functions need doxygen description.

HD-DEN-7605-2 03 May 2021

Should all these alarms be using persistent alarm module from fwcommon? Using persistent alarm module will save some dev test time later on.

HD-DEN-7860-1 11 May 2021

Looks like fpgaActuatorSetPoints is an output and no inputs.

HD-DEN-10153-1 26 Oct 2021

Why the extra blank line?

DG-DEN-9906-1 25 Oct 2021

Fixed

UI-DEN-10206-1 01 Nov 2021

Missing function header.

UI-DEN-8085-1 04 May 2021

I've removed it now. It's the same CAN channel as in the parent class so no need to override it.

DIALIN-DEN-8055-1 06 May 2021

RESOLVED.

DIALIN-DEN-7605-1 11 May 2021

RESOLVED

DIALIN-DEN-7605-1 05 May 2021

Needs a return type

DIALIN-DEN-7605-1 11 May 2021

RESOLVED

DIALIN-DEN-8251-1 05 May 2021

Need file header (copyright, etc.)

HD-DEN-10153-1 26 Oct 2021

Fixed

HD-DEN-9906-1 27 Oct 2021

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-9906-1 26 Oct 2021

Does a toggle function/macro need the second and third parameters, since whatever value it currently has should be reversed?

HD-DEN-9906-1 26 Oct 2021

Could you please explain why the ack timeout increased, is it for POST ack issues or there were other things too?

HD-DEN-9906-1 26 Oct 2021

should be if ( TRUE != getRinsebackCompleted() ) for consistency

DG-DEN-9906-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9906-1 21 Oct 2021

Update function brief - not RO flow.

HD-DEN-10153-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-10153-1 26 Oct 2021

Don't put types here. Also, this function has no outputs. Input is origTreatmentParams.uFVolume_L.

HD-DEN-10153-1 26 Oct 2021

Move this up into accepted condition above. Also, we don't need a public function to set original value since variable is local to this module.

HD-DEN-10153-1 26 Oct 2021

If no params, use void (see SignalUserCancelTreatment above).