•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-8085-1 06 May 2021

RESOLVED

DG-DEN-9906-1 25 Oct 2021

Fixed

DG-DEN-9906-1 25 Oct 2021

Fixed

HD-DEN-10153-1 26 Oct 2021

Fixed

HD-DEN-10153-1 26 Oct 2021

Fixed

HD-DEN-9906-1 27 Oct 2021

currentSubMode is already a U32 - no cast needed.

HD-DEN-9906-1 26 Oct 2021

why here
currentMode is casted while currentSubMode didn't?

data.opMode = (U32)currentMode;
data.subMode = currentSubMode;
DG-DEN-9906-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9906-1 21 Oct 2021

Remove blank line.

DG-DEN-9906-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9906-1 27 Oct 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-10153-1 26 Oct 2021

Add space before and after params (see others above).

DIALIN-DEN-9906-1 28 Oct 2021

RESOLVED.

DIALIN-DEN-9906-1 28 Oct 2021

Fixed

DIALIN-DEN-9906-1 28 Oct 2021

change to 50 ms.

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

UI-DEN-10206-1 01 Nov 2021

This function header is autogenerated by Doxygen getting the comments from the macros.
Please look into the updated DeviceGlobals.h

UI-DEN-10206-1 01 Nov 2021

Updated

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

UI-DEN-10206-1 01 Nov 2021

Function needs header.

UI-DEN-10206-1 01 Nov 2021

Function needs header.

UI-DEN-10206-1 01 Nov 2021

Function needs header.

UI-DEN-10206-1 01 Nov 2021

RESOLVED.

HD-DEN-9906-1 04 Nov 2021

There is nothing to be done in else, so why add it?

UI-DEN-10206-1 04 Nov 2021

Updated in the latest branch. The Link is attached.

UI-DEN-10206-1 03 Nov 2021

feedback in one word (in comment)

UI-DEN-10206-1 05 Nov 2021

RESOLVED.

DG-DEN-9480-1 06 Nov 2021

This function is no longer needed and I deleted it.

DG-DEN-9480-1 04 Nov 2021

Should this be a DEBUG_DENALI comment so Bamboo will prevent a build?

DG-DEN-9480-1 09 Nov 2021

targetDrainPumpSpeed has been changed in the code to targetDrainPumpRPM

DG-DEN-9480-1 04 Nov 2021

Debug code is removed in my branch. Should s/w fault here I think.

HD-DEN-11750-2 03 Mar 2022

RESOVLED IN CODE WALKTHROUGH.

DG-DEN-12931-1 03 Aug 2022

Done.

HD-DEN-8534-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

i added this to fix the headerbar overlaying on all the settings pages. Since the headerbar was just place on top the buttons and titles were hidden behind it.

HD-DEN-8534-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8534-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 29 Apr 2021

Fixed. Compared to target temperature set by HD.

DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 13 Aug 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 03 May 2021

I don't have anything I can do in POST so I removed. There are some checks being done at all times and many checks happening in certain states.

HD-DEN-7605-2 03 May 2021

Parentheses unnecessary.

HD-DEN-7605-2 04 May 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-9411-1 13 Aug 2021

RESOLVED.

UI-DEN-8085-1 04 May 2021

That works too. No need for tee here. I've updated it

UI-DEN-9626-1 20 Sep 2021

1) This sleep helps the Bluetooth driver to load properly.
2) After many, many tests figured the Bluetooth device needs a power cycle after it is loaded and find out if giving it a 5-second delay before setting the "hci" device to up, then it works fine and doesn't need the power cycle anymore. I timed the boot up and it's still under 30 seconds.
3) Yes it shouldn't break the loading of the other prototypes, since they may never even need it.

DIALIN-DEN-8055-1 05 May 2021

Done

DIALIN-DEN-8055-1 06 May 2021

RESOLVED.

DIALIN-DEN-7605-1 06 May 2021

Fixed.

UI-DEN-7752-1 06 May 2021

RESOLVED