RESOLVED in CODE WALKTHROUGH.
RESOLVED.
please put tr() for translation.
Please use 'fontPixel' prefix for your font's pixelSize variables to distinguish between the different properties of the font.
RESOLVED
Made function void.
Needs a return type
Done.
Done
Should we broadcast both bubble detectors' data in one message?
Removed as it is not needed anymore.
RESOLVED IN CODE WALKTHROUGH.
Changed to match your implementation.
If you merge staging into your branch, the temperatures driver converts all the temperature sensors and thermistors.
Please add doxygen comments.
Where do you convert the FPGA data to pressure?
I know bicarb pump "on" request above does not immediately turn the pump on, but I still think we should set target speed before we request pump on.
Please change the byte order for struct.unpack
Start comments w/ capital letter.
Issue is moot with re-factoring of function.
Fixed.
updated.
Function re-factor makes this issue moot.
Fixed
Align "));" with the other lines.
Remove "Meter" from function name.
Not sure what this function would do. I don't think we need it.
Need "Reset" versions of these functions as well. And "value" should probably be "ms" to be more specific.
Let's find out what the mfgr and p/n are.
This function header is autogenerated by Doxygen getting the comments from the macros. Please look into the updated DeviceGlobals.h
No it is uncommented.
Need to restore this code.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
