Done.
I added the command.
I removed it.
Make state a U32 to ensure 4 byte size.
Remove blank line.
Why is this commented out?
Should new RO pump speed signal be monitored?
RESOLVED in CODE WALKTHROUGH.
There are now 2 DG flow sensors (FMP and FMD).
In @details Inputs and Outputs, change dataPublishCounter to fansPublishCounter
I don't see trimmer_heater_state being saved anywhere. If doing [0] tuple indexing here, just assign directly to class variables.
Should efficiency be a float (0.0)?
Should we have a NUM_OF_CHEM_DISINFECT_STATES at end of enum like others?
13 was temporary change for full travel test with Mike. I put it back to 11 for now.
Totally agree. I just created a task for that to follow up DEN-10979. After giving it some thought it needs some dev-ops modifications which will be followed up in that task later.
Fixed
updated.
RESOLVED.
Fixed.
Where it is used?
There is nothing to be done in else, so why add it?
RESOLVED
Needs a return type
Done
Is this still an issue?
Updated in the latest branch, The Link is attached.
Should validate bubble param up top before you use it. S/W fault if invalid. Then don't need the else below.
What information is needed to replace these TBDs?
Remove extra blank line.
Class header missing.
This was not the right place for the function. I deleted the function.
Subtract 0.0 was unnecessary. I deleted it.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
