•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-7605-1 05 May 2021

Typing information missing for parameters
Return type missing

DIALIN-DEN-7605-1 11 May 2021

RESOLVED

DIALIN-DEN-8251-1 11 May 2021

RESOLVED.

DG-DEN-9480-1 09 Nov 2021

This is heaters monitor. This code is not going to be removed but I have commented it to disable any monitoring while the heaters are being monitored. I added a build switch for it.

DG-DEN-7802-1 14 May 2021

The macro already cast the data to U32.

HD-DEN-7860-1 11 May 2021

Same. Validate bubble param at top of function before using it. Then no need for else below.

HD-DEN-7860-1 14 May 2021

This seems to be conflict with FPGA_BLOOD_LEAK_ZERO_STATE_MASK if we are reading from the same FPGA gpio.

HD-DEN-7605-2 03 May 2021

Fix which test to get 1000 ms?

DG-DEN-9480-1 09 Nov 2021

Done.

DG-DEN-9480-1 09 Nov 2021

Done.

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-9480-1 10 Nov 2021

Done.

DIALIN-DEN-9480-1 10 Nov 2021

Done.

DIALIN-DEN-9480-1 10 Nov 2021

Done.

DIALIN-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 09 Nov 2021

Why is all of this code commented out? If not keeping this code, remove it.

HD-DEN-12215-2 09 Mar 2022

Yes. It writes the entire block for MEMORY and SECTIONS so the entire section must be overridden rather than single items.

DG-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-9480-1 09 Nov 2021

This pragma does not appear to be necessary. I have seen where structures with only F32s can have problems with this pragma.

DG-DEN-9480-1 09 Nov 2021

In @details Outputs, remove "fansStatus" because I don't think we count the local variables as outputs

DG-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH

DIALIN-DEN-12121-1 04 Mar 2022

Please update docstring here and above.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH

DG-DEN-9906-1 05 Nov 2021

I don't see where this alarm is being triggered.

DIALIN-DEN-9480-1 09 Nov 2021

Should we have a NUM_OF_FLUSH_STATES at end of enum like others?

DIALIN-DEN-9480-1 09 Nov 2021

I remember there was a case that was not covered so I made this a separate to make sure it always is executed.

HD-DEN-9906-1 05 Nov 2021

I couldn't find TBD anywhere in the code!!!
What is TBD?

DIALIN-DEN-12121-1 04 Mar 2022

Please align the pipes ( | )
fix #5 to #6

DIALIN-DEN-12121-1 04 Mar 2022

update the docstring.

DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12121-1 03 Mar 2022

Please align
remove the empty line.

DG-DEN-12931-1 03 Aug 2022

Done.

DG-DEN-12931-1 03 Aug 2022

Done.

DG-DEN-12931-1 03 Aug 2022

Done.

HD-DEN-12931-2 03 Aug 2022

Done.

HD-DEN-12931-2 03 Aug 2022

Done.

HD-DEN-12931-2 03 Aug 2022

Done.

HD-DEN-12931-2 03 Aug 2022

Done.

DG-DEN-7802-1 03 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7802-1 29 Apr 2021

Replace "good" with "in range". Is this function checking temp range for alarm or for acceptable for dialysate to go to reservoir? If latter, shouldn't the range be target +/- 2°C?

HD-DEN-7605-2 03 May 2021

Copy and paste error. Fixed.

HD-DEN-7605-2 03 May 2021

Fixed.

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 04 May 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-10206-1 03 Nov 2021

Class header missing.

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-10206-1 05 Nov 2021

RESOLVED.

UI-DEN-8085-1 04 May 2021

It is removed now