•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-8085-1 04 May 2021

AlarmVolumeTemp has been removed

DG-DEN-9480-1 06 Nov 2021

Done.

UI-DEN-8085-1 04 May 2021

Done

DG-DEN-11750-1 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-7605-1 06 May 2021

Fixed.

DG-DEN-9480-1 09 Nov 2021

Can this be optimized later?

DIALIN-DEN-9480-1 09 Nov 2021

I made it a float but in Python it does not matter the data types can be changed.

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12121-1 03 Mar 2022

Let's keep it.

UI-DEN-7752-1 06 May 2021

RESOLVED

UI-DEN-8085-1 06 May 2021

RESOLVED

DIALIN-DEN-9480-1 10 Nov 2021

I think it is useful to Dialin users to be able to easily see how many things (switches in this case) are in the list. They can probably get this from enum.length() call too I guess, but I see many other enums in Dialin have the NUM_OF_... to match the C code in f/w.

DG-DEN-9480-1 09 Nov 2021

If pump is not on, do you need to call checkPersistentAlarm with FALSE to reset persistence?

DG-DEN-9480-1 04 Nov 2021

Should this module be removed (replaced by ModeGenIdle)?

UI-DEN-12121-1 09 Mar 2022

RESOLVED
I fixed it in my own branch and merged it into the develop branch.

DIALIN-DEN-8251-1 11 May 2021

Done

DIALIN-DEN-7605-1 11 May 2021

RESOLVED

DIALIN-DEN-7605-1 11 May 2021

RESOLVED

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8251-1 05 May 2021

Need file header.

HD-DEN-7605-2 11 May 2021

Agreed. This is for me to add a check for this error. Will remove comment when I'm done.

UI-DEN-7752-1 11 May 2021

RESOLVED

UI-DEN-7752-1 06 May 2021

Please change to "Event".
Datum: is a message that comes regularly in a certain period.
Event: is a message that comes on a request only and can happen anytime.
Please update the SDDUI 285.

UI-DEN-8308-1 11 May 2021

Are these placeholders? If not, why are they blank?

HD-DEN-7860-1 11 May 2021

Initialize the other 3 fields of the override structure.

HD-DEN-7860-1 11 May 2021

This should be a s/w fault.

HD-DEN-7860-1 11 May 2021

No return value for this function.

HD-DEN-7605-2 05 May 2021

Blood prime last motor count does not seem to get updated except in initBloodPrime(). Should it be updated continuously somewhere?

HD-DEN-7605-2 07 May 2021

Need to remove this comment.

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DIALIN-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DG-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DG-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DIALIN-DEN-12121-1 04 Mar 2022

To be consistent with rest of the code and what has been decided use the standard docstring format as:
@param (int): <description>
@return (int): <description>

DIALIN-DEN-12121-1 04 Mar 2022

unnecessary empty lines.

DIALIN-DEN-12121-1 04 Mar 2022

Please update doctring here and above.

DIALIN-DEN-12121-1 08 Mar 2022

This should be 0xA04F.

HD-DEN-12121-1 06 Mar 2022

This should be a BOOL since you are suing this as a boolean.

DG-DEN-11928-1 18 Mar 2022

I don't see idle mode looking at this flag - comment appears to be wrong.

HD-DEN-12215-2 11 Mar 2022

0xA04E was originally MSG_ID_DG_HD_COMMUNICATION_STATUS_OVERRIDE. It was moved to 0xA008 due to an out of sync error in our lovely excel sheet. MSG_ID_DG_SET_FANS_RPM_ALARM_START_TIME_OFFSET should now be 0xA04E.

Note: These values are what is currently reflected on staging.

DG-DEN-11928-1 18 Mar 2022

This function is never called outside of fill mode - should be private (static) inside .c file.

DG-DEN-11928-1 18 Mar 2022

Removed requestNewOperationMode( DG_MODE_GENE );

HD-DEN-12215-2 11 Mar 2022

Where is 0xA04E?

UI-DEN-8085-1 04 May 2021

Done

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

updated allowOff to canAllowOff

UI-DEN-7752-1 04 May 2021

Done

UI-DEN-7752-1 04 May 2021

Done

DIALIN-DEN-8055-1 05 May 2021

It has been moved to nv_ops_utils.py:

prepare_record_to_send_to_fw