•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-12121-1 04 Mar 2022

Looks like payload sent is not of this type, so why are we using it. Should be BOOL?

DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12121-1 03 Mar 2022

please align
& empty line

UI-DEN-12121-1 03 Mar 2022

There is a comment in the model.
I that changes please don't forget to fix this as well.

UI-DEN-12121-1 03 Mar 2022

Same as hd version
please consult with the users of this information.

DG-DEN-11928-1 18 Mar 2022

Done.

DG-DEN-11928-1 21 Mar 2022

isAvgConductivityOutOfRange is now called in ModeGenIdle

DG-DEN-11928-1 18 Mar 2022

Are these the alarms for when a bottle volume prediction is < 10% left? If so, NoRin and NoEnd should be FALSE and ClrOnly (UsrAck here) should be FALSE.

DG-DEN-11928-1 04 Mar 2022

Why are we not initializing these alarms?

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

change to canRefresh and isActive

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9906-1 04 Nov 2021

Added new alarm ID for dialysate flow out of range.

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14007-1 19 Dec 2022

Updated.

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12121-1 03 Mar 2022

RESOLVED.
The Application will not use that new parameter though.

DIALIN-DEN-8308-1 18 May 2021

Updated

DG-DEN-9480-1 06 Nov 2021

Done.

DIALIN-DEN-7860-1 18 May 2021

Missing typing information for parameters and return type

DIALIN-DEN-7860-1 18 May 2021

Missing typing information for parameters and return type

DIALIN-DEN-7860-1 18 May 2021

Missing typing information for parameters and return type

UI-DEN-10599-1 04 Nov 2021

Removed in the latest branch in The Link attached.

DIALIN-DEN-8251-1 21 May 2021

If you select Edit Configuration -> "add content roots" in PyCharm, it will automatically add /home/denali/Projects/dialin/ to your path before executing the script and there is no longer a need to append to the path in the script. I had selected this option and wasn't having issue running any script.
I've updated all the paths now to support execution from outside of PyCharm.

DG-DEN-7605-1 20 May 2021

I have no preference on that. Data is temporary either way. By reference is a little easier on the stack.

DIALIN-DEN-7860-1 19 May 2021

This should be checked in the function

DG-DEN-7605-1 21 May 2021

Fixed.

HD-DEN-8103-1 19 May 2021

This enum is getting big. Should we put it in its own .h file (AlarmMgmtSWFaults.h) with same doxygen group name (AlarmManagement) that would be included by this header?

HD-DEN-8103-1 21 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 19 May 2021

Done.

HD-DEN-8103-1 21 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 19 May 2021

Removed.

HD-DEN-8103-1 19 May 2021

Neither of these if statements should be executed if treatment is paused (i.e. treatment time is counting down, i.e. we're in dialysis sub-mode of treatment mode and not delivering a saline bolus).

HD-DEN-8103-1 19 May 2021

Need to add a get function for private variable totalSalineVolumeDelivered in Dialysis module.

HD-DEN-8103-1 21 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 21 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 09 Nov 2021

Done.

DG-DEN-9480-1 09 Nov 2021

Done.

HD-DEN-9480-1 09 Nov 2021

Removed the code.

DIALIN-DEN-9480-1 09 Nov 2021

I have not done this in Dialin. I do not know if it is necessary.

DIALIN-DEN-8251-1 21 May 2021

Done - just FYI I have added type hints in my Sprint 45 branch for the dg classes. So it hasn't been updated almost everywhere inside the dg folder on this Sprint 44 branch

DIALIN-DEN-8251-1 21 May 2021

Done

DIALIN-DEN-9480-1 10 Nov 2021

I think it still helps with readability. A 0.0 initialize value indicates that the developer intends this to be a float.

DG-DEN-9480-1 09 Nov 2021

No control - remove TODO.

DIALIN-DEN-8251-1 21 May 2021

RESOLVED.

DG-DEN-9480-1 09 Nov 2021

Why can't we monitor now?

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 05 Nov 2021

What's happening here? Why subtract 0?