•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 05 Nov 2021

Who would call this function?

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12215-2 08 Mar 2022

Why does door need to be closed for this state?

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH

DIALIN-DEN-12121-1 09 Mar 2022

RESOLVED
Thanks,

DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12121-1 04 Mar 2022

Add blank line after.

UI-DEN-12121-1 03 Mar 2022

This seems a big type for just a boolean value to me.
Please check the FW code as well.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7860-1 18 May 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-10206-1 06 Nov 2021

Has been removed in the latest branch. The Link attached.

DIALIN-DEN-8308-1 18 May 2021

Updated

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-11750-2 03 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-8308-1 18 May 2021

I'm not aware of this function usage, but in general, some of these fields provided by HD for later use, and UI is not using them and some other has recently been used.

DIALIN-DEN-7860-1 18 May 2021

Should have definitions for 0 and 1 similar to fluid/air.

DIALIN-DEN-8308-1 17 May 2021

Add space after comma right before hasParameters.

HD-DEN-8103-1 19 May 2021

Let UI timestamp

UI-DEN-8495-1 24 May 2021

These definitions force dialin to talk on an HD/DG channels in order to simulate the UI. Seems like a security risk and that the UI should be able to tell the difference.

DIALIN-DEN-7820-1 25 May 2021

Typing information needs to be added for all new "cmd" methods to be consistent with the rest of dialin. The older commands can be updated at a later time, but new ones should follow this standard.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 09 Nov 2021

@details Inputs and Outputs need update

HD-DEN-9480-1 09 Nov 2021

Align comment.

DIALIN-DEN-9480-1 09 Nov 2021

This brief looks incomplete.

DIALIN-DEN-7820-1 24 May 2021

I find it very hard to believe it wouldn't be possible to support that screen and not pass the message id and channel ID to this function.
One function should not be supporting multiple message IDs. You just need more functions to support that screen.

DIALIN-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DG-DEN-11928-1 04 Mar 2022

But is it set to correct rate for product/delivery? Check with Dara. Produce/delivery rate should be set by HD I think, so may not be same as set in previous state.

UI-DEN-12121-1 03 Mar 2022

remove the empty line.

DIALIN-DEN-12121-1 09 Mar 2022

RESOLVED
Thanks,

DG-DEN-12121-1 09 Mar 2022

We need to decide what DG should do if HD comm times out.
Alarm may not make sense since HD apparently not connected to receive/display alarm.
Appropriate action may be mode specific.

DIALIN-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DIALIN-DEN-12121-1 04 Mar 2022

Please use the new conversion methods, from now on.
I believe we decided to use them until you find time to update all the others.

DIALIN-DEN-12121-1 09 Mar 2022

RESOLVED
Thanks,

DIALIN-DEN-12121-1 09 Mar 2022

RESOLVED.

DG-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

HD-DEN-12121-1 06 Mar 2022

Why was this include removed? Do you not need it for the treatment parameters commands?