•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH

DG-DEN-9480-1 09 Nov 2021

Add fansStatus to @details Inputs, since it is read at line 593

DG-DEN-9480-1 09 Nov 2021

drainPumpDAC on line 611 should be added to @detail inputs?

DG-DEN-9480-1 09 Nov 2021

In @detail outputs, add signalNewRPMRequest

DG-DEN-11928-1 04 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH

HD-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9480-1 09 Nov 2021

Either testSetStopRTC() should return a BOOL and set result to that BOOL or you need to just set result to TRUE in this if scope - otherwise the Ack sent below will always be a Nak.

DIALIN-DEN-9480-1 09 Nov 2021

If doing [0] tuple indexing here, just assign directly to class variable.

DG-DEN-11928-1 07 Mar 2022

Updated code to check for the difference in percent of conductivity between CD1 and CD2 and make sure it is < 5% otherwise alarm.

DG-DEN-12121-1 07 Mar 2022
DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12121-1 09 Mar 2022

RESOLVED
Thanks,

DG-DEN-12121-1 09 Mar 2022

Fixed. Thanks!

DG-DEN-12121-1 06 Mar 2022

We do not have doxygen comments for the function declarations.

DG-DEN-12121-1 09 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12121-1 04 Mar 2022

Add space beetween if and (.

UI-DEN-12121-1 03 Mar 2022

remove Data, and fix infoText in doc.

UI-DEN-12121-1 03 Mar 2022

the "Data" is redundant.
in the log, there is a section for the type if is data will be ",D,"
Please, update all the other models and the "| infoText|" in the header documents as well.

HD-DEN-12215-2 08 Mar 2022

Should we check pump track switch too?

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7605-2 18 May 2021

This will be addressed in DEN-8103.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

this was added as part of fixing the header bar sitting on top of the settings pages as it was not needed anymore

HD-DEN-9480-1 10 Nov 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-8495-1 24 May 2021

change (instead of changed)

DIALIN-DEN-7860-1 19 May 2021

Blood leak currently outputs the states of the state machine to the console as it changes. If we want to get the state, we will need to implement it here and for Blood Leak as well. How are the other Dialin API libraries handling it? We need to be consistent across here.

DIALIN-DEN-12121-1 09 Mar 2022

RESOLVED
Thanks,

UI-DEN-8495-1 25 May 2021

RESOLVED.

DG-DEN-13598-2 26 Sep 2022

RESOLVED in CODE WALKTHROUGH

HD-DEN-8103-1 19 May 2021

Done.

UI-DEN-8308-1 25 May 2021

RESOLVED

UI-DEN-8308-1 24 May 2021

The filename needs to be updated

DG-DEN-8103-1 20 May 2021

The only preference is to put TRUE first if it is == such as below.

HD-DEN-8103-1 19 May 2021

Change PERIOD to PERIODIC?

HD-DEN-8103-1 19 May 2021

This should be available from syringe pump driver - getSyringePumpVolumeDelivered().

DIALIN-DEN-8251-1 21 May 2021

RESOLVED.

DIALIN-DEN-8251-1 21 May 2021

RESOLVED.

UI-DEN-8308-1 21 May 2021

This could be clearer. From just reading this it's unclear what the purpose of the footer is

DG-DEN-11928-1 04 Mar 2022

Ok, I see that. I don't think averageConductivity is the right name for this. Looks more like a pctDifferenceInConductivity or something like that.

DG-DEN-12121-1 08 Mar 2022

Update. Function will be reworked to have proper override control instead of always flipping to True.

DIALIN-DEN-7860-1 24 May 2021

RESOLVED.

DIALIN-DEN-12121-1 09 Mar 2022

RESOLVED
Thanks,

UI-DEN-8308-1 24 May 2021

It's like running the cppcheck script that we keep the outputs.