Copyright is missing
RESOLVED
This filename needs to be updated
Later please be consistent with types, (int) is used everywhere RESOLVED Thanks,
Remove commented out alarms.
RESOLVED in CODE WALKTHROUGH.
It has been addressed in another code review for another branch ( TxLog, Disinfection ). If an API is missing that shall be addressed in a separate task.
Add blank line between declarations and code.
Alarm is recoverable. Should go to fill paused state. Paused state should go back to this test inlet water quality state when alarm acknowledged.
We should stop all the actuators prior to transitioning to standby.
Fixed. Thanks!
Implemeted. DG Conductivity data is within dg_simulator. Thanks!
RESOLVED Thanks,
Do we always want to override status to TRUE?
Fix #9 to #10
remove Data, and fix infoText in doc.
Moved and used getSwitchStatus to ensure overrides work.
Good catch. Updated.
Why is alarm commented out? It is still checked below so we should initialize it here.
Removed fillBottlesNeedPrimeFlag and use the existing isThisFirstFill
Removed isBadFill() function and used signal function isAvgConductivityOutOfRange( void );
Do we want to check pump track switch too?
This function is obsolete since the fillBottlesNeedPrimeFlag is replaced by isThisFirstFill flag in ModeFill.c
Should set back to start state for next time.
This request for idle mode is already present at bottom of function.
Flush lines state is obsolete now. Let's remove it and go straight to flush water state.
We might want to keep request for idle mode here.
Done.
did we want to keep these loose tolerances from the demo?
RESOLVED.
RESOLVED in CODE WALKTHROUGH
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
