•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-11928-1 22 Mar 2022

Might want to move empty bottle checks above tare check.

DIALIN-DEN-7820-1 25 May 2021

The fromHD flag should be removed since there is a separate dg simulator
Typing information still needs to be added

DIALIN-DEN-11928-1 31 Mar 2022

RESOLVED.

DG-DEN-11928-1 18 Mar 2022

The fillStatus.fillEmptyAcidBottleDetected is set to TRUE to signal drain mode that empty bottle is detected
This flag is checked at the end of the drain mode.

HD-DEN-11928-2 22 Mar 2022

Removed line // payload.alarmsFlags |= ( almStatus.noNewTreatment ? BIT_BY_POS(ALARM_STATE_FLAG_BIT_POS_NO_NEW_TREATMENT) : 0 );

HD-DEN-12215-2 22 Mar 2022

Done.

DG-DEN-11928-1 18 Mar 2022

Aren't we doing this check at end of drain mode? I don't think we should be checking here.

DIALIN-DEN-11928-1 31 Mar 2022

RESOLVED.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 24 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 24 May 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12716-1 01 Jul 2022

duplicates removed.

HD-DEN-12847-1 13 Jul 2022

I don't think this does what we want anymore. Need to revisit VC issue.

HD-DEN-12847-1 13 Jul 2022

General comment - nothing to be done. Generally only need F suffix on #defines as they are not inherently typed. RESOLVED in CODE WALKTHROUGH.

HD-DEN-12847-1 13 Jul 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13167-1 22 Jul 2022

I though cycle was an enum (start/final), not a boolean. Should we be looking for final (not TRUE)?

DG-DEN-12974-1 03 Aug 2022

Separate assignments or at least put all in same line.

DG-DEN-12974-1 03 Aug 2022

Separate assignments or at least put all in same line.

DG-DEN-12931-1 22 Jul 2022

Should be s/w fault. Add TODO or trigger s/w fault now.

DG-DEN-12931-1 23 Jul 2022

Keep this blank line.

DG-DEN-12931-1 23 Jul 2022

Keep this blank line.

DIALIN-DEN-12716-1 26 Jul 2022

I totally agree.
This is the Dialin design, I am just using the API.
I think we should create a task on the Dialin board and follow up on that ticket.

HD-DEN-13141-6 21 Jul 2022

Why?

DG-DEN-12974-1 03 Aug 2022

Use explicit condition ( TRUE == resetStateTimer ).

DG-DEN-12974-1 03 Aug 2022

Separate assignments or at least put all in same line.

DG-DEN-12974-1 03 Aug 2022

Separate assignments or at least put all in same line.

DG-DEN-12974-1 03 Aug 2022

This looks like it allows flows > maximum now. What is the intent here?

DG-DEN-12931-1 03 Aug 2022

Done.

DG-DEN-12931-1 03 Aug 2022

Done.

DG-DEN-12931-1 03 Aug 2022

This issue will be addressed in DEN-13460.

DG-DEN-12931-1 03 Aug 2022

This is a temporary number and has been removed in DEN-13460.

DG-DEN-12931-1 03 Aug 2022

Done.

DG-DEN-12931-1 03 Aug 2022

Done.

DG-DEN-12931-1 03 Aug 2022

This function covers both DVT and V3 and depending on the status it pick the conversion coefficients.

DG-DEN-12931-1 03 Aug 2022

Done.

DG-DEN-12931-1 03 Aug 2022

Done.

DG-DEN-12931-1 23 Jul 2022

Is it really true that all function below this line are DVT?

DG-DEN-9480-1 10 Nov 2021

Done.

UI-DEN-12121-1 09 Mar 2022

I fixed it in my own branch and merged it into the develop branch.

DIALIN-DEN-7860-1 24 May 2021

Removed.

UI-DEN-12121-1 09 Mar 2022

RESOLVED
I fixed it in my own branch and merged it into the develop branch.

UI-DEN-12121-1 09 Mar 2022

RESOLVED
I fixed it in my own branch and merged it into the develop branch.

DIALIN-DEN-7860-1 19 May 2021

Actually they should be in multiples of 50ms (general task). I mistakenly had a few functions written with 10ms (priority task) but that is not correct. I don't think it would cause an error, but non-multiple intervals will be floored to nearest lower multiple of 50 ms by the f/w I suspect.

HD-DEN-8103-1 21 May 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 21 May 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7605-1 21 May 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-8308-1 22 May 2021

Added

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.