Agree. Dara, make these look something like "C_CALIBRATION_CMD".
Why is this var declared in the if and all others are at top of function?
Done
Not if the #define is used by other modules. In this case, this #define is used by ModeInitPOST.c
There will not be any alarms for the software configurations.
Done.
RESOLVED in CODE WALKTHROUGH.
Remove extra blank line.
Do we need this state?
Add another blank line here.
Remove blank line.
Why not initialize this variable? Why removed? If removing rinse state, remove variable and state entirely.
Why only DG?
Don't we still want to know if it's valid - and revert to defaults if not?
Does this need to be moved above the first condition?
Is this addtogroup doxygen redundant with above?
Rather than UI sending this message to f/w so f/w can send event message back to UI to log it, maybe UI can just log it itself?
Can we remove this code now?
No. Removed.
updated.
Will add back in.
I fixed it in my own branch and merged it into the develop branch.
RESOLVED I fixed it in my own branch and merged it into the develop branch.
RESOLVED
Missing .value at the end of the message id
It has to be input and output.
RESOLVED.
Added "pressuresDataPublicationTimerCounter" variable to @details Outputs
I do not see in this function where you read from valveAirTrapStatus. Remove it from @details Inputs.
RESOLVED in CODE WALKTHROUGH
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
