Comment Search

Removed requestNewOperationMode( DG_MODE_GENE );

Add another blank line here.

This is actually an input because it is used to make a decision.

valvesStatus should be in Inputs not Outputs

IT has been recently removed from the diagnostics screen.
I'm not sure when it will be needed to get back again on that screen.
Probably keeping it is a lot easier than reimplementing it.

Timeout has no data.

Just delete this code.

I think this should just be an else.

RESOLVED.

Add doxygen

very good point Sean.
Coco ignores it but logs each one which I think it more bothers us than coco.
I am going to disable them too.

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

For all DG faults, the NoRes should be TRUE, but the NoRin and NoEnd should be FALSE so user can perform rinseback and/or end treatment.

Need an else so volume isn't undefined if not acid or bicarb. Should probably also trigger a s/w fault.

No longer need these new fields - just fault on low flow now.

Can local declarations be moved to top of function?

Can we change "r" to "reservoir"?

Remove blank line.

Done.

Put declarations at top of scope.

Can we put all local declarations at top of function?

Can't we just pass a zero in function param list below? Why need a local variable?

Sean Nash, Dara Navaei,
Please create a case for UI when something like the HD/DG changes in the common repository which definitely impacts UI behavior, and sometimes stops UI build.
It should be done when the actual code is changed in the common repo, not the dialin.
I am going to update UI now but the comment is for later.

Thanks for catching that,
Fixed.