•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-8514-1 28 May 2021

Thanks for catching that,
Fixed.

DD-LEAH-225-1 16 Oct 2024

Done.

DD-LEAH-225-1 16 Oct 2024

Remove extra blank line.

DG-DEN-9480-1 10 Nov 2021

Done.

DG-DEN-9480-1 10 Nov 2021

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

DG-DEN-11928-1 21 Mar 2022

Assigned MSG_ID_DG_FILL_MODE_DATA = 0xAE, ///< DG broadcast of fill mode data such as used acid & bicarb volume
Updated Message List.xlsx (Denali Tab, Row = 142) with 0xAE00 DG Fill Mode Data

HD-DEN-9480-1 10 Nov 2021

Done.

HD-DEN-9480-1 10 Nov 2021

Spelling error VALVE_CONTORL

HD-DEN-9480-1 10 Nov 2021

Remove 2nd and 3rd variables from Inputs

HD-DEN-9480-1 10 Nov 2021

@details Inputs: should be none

HD-DEN-9480-1 10 Nov 2021

Remove valvesStatus from @details Inputs.

DG-DEN-11928-1 18 Mar 2022

Corrected
Initialized in case DG_GEN_IDLE_MODE_STATE_START:

// Execute current generation idle state
switch ( genIdleState )
{
case DG_GEN_IDLE_MODE_STATE_START:
badFillState = DG_HANDLE_BAD_FILL_STATE_START;
genIdleState = handleIdleStartState();
break;

HD-DEN-12215-2 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-12258-1 18 Apr 2022

Disabled the "coco end"s as well.

UI-DEN-12258-1 26 Apr 2022

RESOLVED.

HD-DEN-12441-3 11 May 2022

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

HD-DEN-12441-3 11 May 2022

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

DG-DEN-12845-2 20 May 2022

Shouldn't this be at end of header file?

HD-DEN-12845-2 25 May 2022

Remove blank line.

HD-DEN-12224-16 18 May 2022

We want release s/w to be fully enabled with no special test code. SW configs are structured such that a disabled config is what is wanted for release s/w and so forcing all s/w configs to be disabled in a release build ensures we don't accidentally leave a config in the wrong state.

DG-DEN-12224-7 21 May 2022

Remove extra blank line.

DIALIN-DEN-12358-1 07 Apr 2022

Unnecessary/confusing use of ternary-if.
please change to:

self.alarm_clr_top_only[alarm_id[0]] = alarm_cto[0] == 1
DG-DEN-12224-7 22 May 2022

Remove blank line.

DG-DEN-12224-7 22 May 2022

Do we still need this build switch?

DG-DEN-12224-7 21 May 2022

Remove extra blank line.

DG-DEN-12224-7 21 May 2022

Is there a rationale for these blank lines in random places?

DG-DEN-12224-7 22 May 2022

Put declarations at top of scope.

HD-DEN-12224-16 22 May 2022

For safety I do it here.

HD-DEN-12224-16 22 May 2022

The other states ignore this flag and I have to set it here since this is a request.

HD-DEN-12224-16 22 May 2022

Done.

HD-DEN-12224-16 22 May 2022

Done.

HD-DEN-12224-16 23 May 2022

Done.

HD-DEN-12224-16 23 May 2022

Done.

DG-DEN-12224-7 23 May 2022

This is the place that the RO water usage can be updated with only one function call.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-12224-7 23 May 2022

When the NV record data is requested, the number of sensors to be checked has to be provided for error check. But this is not a sensor so 0 is passed. I defined a variable for it to be readable.

DG-DEN-12224-7 23 May 2022

Yes it is one of the POST states of the NV data management.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-12224-7 23 May 2022

Done.

HD-DEN-12224-16 20 May 2022

Did we want this offset to revert to zero here or should Dialin have to do a reset?

HD-DEN-12224-16 23 May 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 18 May 2022

NoBRcr should be TRUE and NoDRcr should be FALSE.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 25 May 2022

Done.

DG-DEN-12224-7 25 May 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12224-7 21 May 2022

Remove extra blank line.

HD-DEN-12931-2 12 Jul 2022

Add blank line before return.