•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-12974-1 28 Jun 2022

This will be addressed in DEN-12931.

DG-DEN-12847-1 01 Jul 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12847-1 30 Jun 2022

Added index variable and removed duplication of code.

HD-DEN-12847-1 01 Jul 2022

Function no longer takes a boolean parameter.

HD-DEN-12847-1 30 Jun 2022

It's not so much empty and full - neither is empty - it's more like start and final weights. Consider renaming these.
Also, consider moving these declarations to top of module. Nothing wrong with them being here, but the style for this code base has been to declare everything at top of module.

HD-DEN-12847-1 01 Jul 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12847-1 30 Jun 2022

Is fabs() appropriate here?

HD-DEN-12847-1 30 Jun 2022

I think this whole condition should be removed. If we are taking baseline reading for a reservoir, it is not time to do the drift check yet. Just need to save the readings here.

DG-DEN-12847-1 01 Jul 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-12847-1 01 Jul 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12716-1 01 Jul 2022

Wow, eagle-eye,
duplicates removed.

DIALIN-DEN-12716-1 01 Jul 2022

Wow, eagle-eye,
duplicates removed.

UI-DEN-12716-2 06 Jul 2022

RESOLVED

HD-DEN-12847-1 30 Jun 2022

Remove extra blank line.

DIALIN-DEN-12716-1 01 Jul 2022

What criteria is used to determine whether a message is included in this list?

DG-DEN-12974-1 28 Jun 2022

Can we just remove this code now?

DG-DEN-8103-1 29 May 2021

Removed the wrapper function. For now, only support one type of 32-bit CRC algorithm.

HD-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-8103-1 29 May 2021

Good point. The module has been moved to fwcommon.

DIALIN-DEN-9480-1 11 Nov 2021

RESOLVED.

HD-DEN-9480-1 10 Nov 2021

Remove valvesControlStatusBits from Inputs since it is not being used in this function

DG-DEN-11928-1 22 Mar 2022

When transition to
case DG_MODE_STAN:
currentSubMode = transitionToStandbyMode();
break;
transitionToStandbyMode is called and deenergizeActuators() is invoked to init all actuators to desired state.

// Turn off the UV reactors
turnOffUVReactor( INLET_UV_REACTOR );
turnOffUVReactor( OUTLET_UV_REACTOR );

// De-energize all the valves
setValveStateDelayed( VPI, VALVE_STATE_CLOSED, DELAY_VALVE_MS );
setValveStateDelayed( VBF, VALVE_STATE_CLOSED, DELAY_VALVE_MS );
setValveStateDelayed( VSP, VALVE_STATE_CLOSED, DELAY_VALVE_MS );
setValveStateDelayed( VPD, VALVE_STATE_DRAIN_C_TO_NO, DELAY_VALVE_MS );
setValveStateDelayed( VPO, VALVE_STATE_NOFILL_C_TO_NO, DELAY_VALVE_MS );
setValveStateDelayed( VDR, VALVE_STATE_DRAIN_C_TO_NO, DELAY_VALVE_MS );
setValveStateDelayed( VRC, VALVE_STATE_DRAIN_C_TO_NO, DELAY_VALVE_MS );
setValveStateDelayed( VRO, VALVE_STATE_R1_C_TO_NO, DELAY_VALVE_MS );
setValveStateDelayed( VRD1, VALVE_STATE_CLOSED, DELAY_VALVE_MS );
setValveStateDelayed( VRD2, VALVE_STATE_CLOSED, DELAY_VALVE_MS );
setValveStateDelayed( VRI, VALVE_STATE_R1_C_TO_NO, DELAY_VALVE_MS );
setValveStateDelayed( VRF, VALVE_STATE_R2_C_TO_NO, DELAY_VALVE_MS );

requestConcentratePumpOff( CONCENTRATEPUMPS_CP1_ACID );
requestConcentratePumpOff( CONCENTRATEPUMPS_CP2_BICARB );
signalROPumpHardStop();
signalDrainPumpHardStop();
stopHeater( DG_PRIMARY_HEATER );
stopHeater( DG_TRIMMER_HEATER );

DG-DEN-11928-1 04 Mar 2022

Is ACID_TEST_CD2_TCD the right reference value for this check? Should we even be using the isValueWithinPercentRange function here?
I think averageConductivity is already a percentage so you can just see if it's less than 5%.

HD-DEN-13598-2 27 Sep 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 22 Mar 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-9480-1 11 Nov 2021

RESOLVED in CODE WALKTHROUGH

DG-DEN-11928-1 23 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-225-1 16 Oct 2024

Done.

DG-DEN-11928-1 23 Mar 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-11928-1 30 Mar 2022

It is initialized in the init function and it is staggered.

DG-DEN-12224-7 21 May 2022

Can we put all of the local declarations at the top of the function?

DG-DEN-11928-1 30 Mar 2022

Initialized hdLostCommStartTime_ms
in void initGenIdleMode( void )

HD-DEN-13834-1 29 Sep 2022

Done.

DIALIN-DEN-11928-1 31 Mar 2022

Done.

DG-DEN-11928-1 31 Mar 2022

RESOLVED in WALKTHROUGH.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-12224-7 21 May 2022

Remove blank line.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-12845-2 13 Jun 2022

Done.

HD-DEN-12224-16 22 May 2022

Done

HD-DEN-12224-16 22 May 2022

Done.

DG-DEN-12224-7 23 May 2022

This is one the very few build switches in case we need to isolate the firmware to just an eval board.

HD-DEN-12224-16 20 May 2022

Remove blank line.

DG-DEN-12224-7 23 May 2022

They should not be switches. They are all caps.

HD-DEN-12224-16 23 May 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-12224-16 20 May 2022

Remove blank line.

HD-DEN-12224-16 20 May 2022

I don't think we should exit normal mode in TreatmentStop sub-mode.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

RESOLVED in CODE WALKTHROUGH.