Comment Search

The fault has been implemented. As soon as all of the testing is done, I will remove this code.

Yes we will further test this in DVT.

RESOLVED IN CODE WALKTHROUGH.

I don't think this results in an elapsed time. It's just a different start time. The calcTimeSince below gives you the elapsed time.

Im assuming that this if statement covers sub modes like Saline and Blood Prime. How do we know during blood prime, specifically, that we would not be dealing with an edge case in treatment parameters for the patient (Ex: -300 mmHg to -270 mmHg) and triggering a false positive alarm?

Note: I dont know actual patient bp values but these are currently acceptable treatment parameters for arterial pressure limits.

Will be addressed in in DIAL-171.

Please implement a getter for wet_self_test_states

10-20 seems like a better number, but my sample size is small so I did not change it.

RESOLVED in CODE WALKTHROUGH.

Function re-factor makes this issue moot.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Coding standard wants just one return statement in a function. Set a local boolean in if/else and return that.

Not sure a list is appropriate. And if list does make sense, should probably be a list of messages that do require ACK (as generally we do not want Dialin ACKing - we want Dialin to be passive and let HD/DG/UI do the ACKing). Let's discuss with Michael.

Done.

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

RESOLVED

RESOLVED in CODE WALKTHROUGH.

Done

It is not used for any decision making so it is only output.

I fixed this.

RESOLVED IN CODE WALKTHROUGH

Replace both Inputs and Outputs with valvesPostionOverride.

Sean is OK with current implementation.

RESOLVED in CODE WALKTHROUGH.