•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15367-1 12 Jun 2023

Done

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 29 Sep 2022

Done.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15367-1 09 Jun 2023

Blank line between declaration and code.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 29 Sep 2022

Done.

HD-DEN-13834-1 29 Sep 2022

It is up to date.

DIALIN-DEN-13460-1 29 Sep 2022

RESOLVED.

HD-DEN-14001-1 30 Sep 2022

Need to save data to dataPtr so calling function gets the data.

HD-DEN-14000-1 10 Oct 2022

Comment removed, Ack kept.

DG-DEN-13834-1 12 Oct 2022

I guess what I'm asking is - can loops be combined? Is there any reason not to convert and monitor each sensor before moving to next?

DG-DEN-13834-1 12 Oct 2022

But, since there is not loop, you can arrange default to be reached in vectorcast - so no need to have #ifndef.

HD-DEN-14001-1 13 Oct 2022

Remove this blank line.

HD-DEN-14000-1 07 Oct 2022

Change to "0 == disinfectCancelReqID"

HD-DEN-13903-2 12 Oct 2022

During Saline circ blood circuit state, we are also running the BP at the same rate as purge air as we monitor the level. Do we want the first pass of that state to be ramped up? Also, DPi?

HD-DEN-13903-2 12 Oct 2022

Fixed. Thanks!

HD-DEN-13903-1 12 Oct 2022

Fixed. Thanks!

HD-DEN-13903-2 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 30 Sep 2022

I think the enum from commit fbb6603 was fine as it was. I still think we should be doing only 1 read per 250ms interval and I think the one function with the large switch statement based on these enums was the way to achieve that - with the multiple status1..5 and remaining capacity1..5 enums spaced out to get them read more frequently.
And I think the individual cases for the higher frequency registers could just call the high frequency broadcast function whenever a new value is read for those registers. And so the slower broadcast could stay at end of list in that switch statement.

HD-DEN-14000-1 07 Oct 2022

Why absolute? If can't handle negative speeds, maybe should floor at zero instead?

HD-DEN-13834-1 28 Sep 2022

Should be hdUsageInfoGroup in header.

DG-DEN-13834-1 17 Oct 2022

Done.

HD-DEN-13834-1 17 Oct 2022

This is an old code and it has been removed.

HD-DEN-13834-1 17 Oct 2022

It is uncommented.

HD-DEN-13834-1 17 Oct 2022

Done.

DG-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 04 Oct 2022

Does didTimeout support a 1ms timeout?

DG-DEN-14316-1 21 Nov 2022

Remove blank lines and commented out ode.

HD-DEN-14150-1 18 Oct 2022

Done. Updated with SW_CONFIG_ENABLE_VALUE is the first item.

HD-DEN-14001-1 28 Sep 2022

Update function header.

HD-DEN-14101-1 17 Oct 2022

Update function header.

HD-DEN-14150-1 07 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 07 Nov 2022

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

DG-DEN-14316-1 21 Nov 2022

Update header.

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

DG-DEN-14197-1 21 Nov 2022

Do we need a maximum? If so, magic number.

DG-DEN-14197-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14000-1 21 Nov 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-14344-3 22 Nov 2022

This code was auto-generated by HALCoGen. Did you want me to revert the auto-generated code?

DG-DEN-14316-1 21 Nov 2022

Remove

HD-DEN-14344-3 22 Nov 2022

Align comments.

HD-DEN-14344-3 22 Nov 2022

Add blank line after separator.

DG-DEN-14356-1 22 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 23 Nov 2022

Fixed. Thanks!

HD-DEN-14344-3 23 Nov 2022

Function Removed. Thanks!

HD-DEN-14344-3 23 Nov 2022

Function removed. Thanks!

DG-DEN-14316-1 21 Nov 2022

Update header.

HD-DEN-14344-3 22 Nov 2022

Add blank line after separator.

HD-DEN-12931-2 03 Aug 2022

We only do that if we do the == comparison. This is to make sure the compiler errors out if only one = is put instead of ==.