•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13598-2 26 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-12931-2 03 Aug 2022

Blood leak is still in development. This will be addressed in DEN-13460.

HD-DEN-12931-2 03 Aug 2022

Done.

HD-DEN-13598-2 26 Sep 2022

Already removed blank line.

DG-DEN-12931-1 04 Aug 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1 12 Jun 2023

Update function header.

HD-DEN-13834-1 29 Sep 2022

Done.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15367-1 12 Jun 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14316-1 30 Nov 2022

Alignment

HD-DEN-15367-1 12 Jun 2023

That is true I fixed it.

HD-DEN-15367-1 09 Jun 2023

Blank line between declaration and code.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 04 Oct 2022

Why are we hiding this condition from Vectorcast?

DG-DEN-13834-1 06 Oct 2022

Why the change?

HD-DEN-13903-1 12 Oct 2022

This whole block of code ( lines 248 - 304 ) was removed in when staging was merged in and not reflected on crucible.

HD-DEN-14150-1 18 Oct 2022

Removed the commented-out line.

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 06 Oct 2022

GENERIC_CONFIGURE == disinfectCancelRegID

DG-DEN-13834-1 12 Oct 2022

No this was the variable that was keeping track of the time that the reactor was on with no flow. This was to turn on the reactor if the flow is recovered. Per the SRSs we fault if the reactors are on with no flow.

DG-DEN-13834-1 12 Oct 2022

Done.

DG-DEN-13834-1 12 Oct 2022

These are implemented like HD is implemented.

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

DG-DEN-13834-1 12 Oct 2022

Please see the comments.

HD-DEN-13903-1 12 Oct 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-13903-1 12 Oct 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

#define name (or at least comment) should mention this is max deviation between redundant sensors.

DG-DEN-13834-1 12 Oct 2022

Warrants a comment.

HD-DEN-13834-1 17 Oct 2022

We only put the define on the left of the comparison is "==" just to make sure if we put only one "=", the compiler will catch it.

HD-DEN-13834-1 17 Oct 2022

The status of FALSE is set at the top when the variable is declared. If the conversion was successful, the status is set to TRUE.

HD-DEN-14150-1 17 Oct 2022

Update function header. dialysateInPumpRotorCounter.data, dipStopAtHomePosition also output.

HD-DEN-14150-1 18 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 05 Oct 2022

BatteryStatusData is also an input

HD-DEN-14175-1 07 Nov 2022

None of these structures appear to require packing - all 32-bit fields.

HD-DEN-14344-3 23 Nov 2022

AirPump.h should be before AirTrap.h.

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

DG-DEN-14197-1 21 Nov 2022

This line of code is not referencing a field in a structure. I do not see it declared anywhere. I've been unable to build this branch (I think because there is no fwcommon branch) so somebody may have fixed this in develop.

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

DG-DEN-14316-1 21 Nov 2022

Alignment

DG-DEN-14000-1 21 Nov 2022

Does CPLD need to include sys comm?

HD-DEN-14344-3 22 Nov 2022

This code was auto-generated by HALCoGen to link PIN 36. Did you want me to revert the auto-generated code?

HD-DEN-14344-3 22 Nov 2022

Add doxygen comment to top of structs and enums.

HD-DEN-14344-3 22 Nov 2022

Ok. Not sure how HALCoGen got ahead of generated code for a time.
RESOLVED in CODE WALKTHROUGH.

HD-DEN-14099-1 28 Nov 2022

Updated to venous. Good catch.

DG-DEN-14356-1 22 Nov 2022

I renamed the #define to be consistent with the latest changes.

HD-DEN-14344-3 23 Nov 2022

Fixed. Thanks!

HD-DEN-14344-3 23 Nov 2022

Fixed. Thanks!

HD-DEN-14099-1 28 Nov 2022

Updated to reset valve position and flag.