Does this volume ever get read from NV memory at startup?
Clear alarm condition, not alarm.
We have a banner above separating system message helpers from Dialin message helpers. Should only be Dialin message helpers below that banner. I think there are a lot of these in the wrong place.
the old comment is correct. The else branch statement handles no content.
We should improve the Dialin coding someday! RESOLVED
Moved code as suggested.
Done.
Looks like this is in wrong spot.
RESOLVED in CODE WALKTHROUGH.
Not sure if this is an issue - but looks like this clear alarm condition check can happen even when occlusion level after install hasn't been set yet.
Add blank line between functions.
RESOLVED
RESOLVED in CODE WALKTHROUGH
There will not be any alarms for the software configurations.
Removed 2 unused thresholds: #define CONDUCTIVITY_WHEN_ACID_JUG_EMPTY 10000.0 #define CONDUCTIVITY_WHEN_BICARB_JUG_EMPTY 12000.0
RESOLVED.
Done
RESOLVED IN CODE WALKTHROUGH
Remove valvesStatus from Inputs since the code where it used as Inputs is commented out
Incorrect function name here.
Added signal function setBadAvgConductivityDetectedFlag( BOOL flag ) in ModeGenIdle.
Maybe remove thresholds for now as we are not using them yet.
Reviewed requirement - it is obsolete.
Aligned this comment with other comments ///< Used to schedule dialysate fill data publication to CAN bus.
RESOLVED in WALKTHROUGH.
Yes, Sean Nash, a Jira task, I meant. RESOLVED.
I reordered it. Some of the controllers also do the monitoring as well since we are not planning to use the priority task rate for all the monitors.
Not yet.
Thanks Michael, fixed it.
Removed the blank lines.
I added another item to be initialized but some of them are related to turning of the heater when there is no flow that are removed.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
