Moved.
This file has been deleted.
Removed.
Is this dead code? Can we remove?
Fixed. Thanks!
Fixed... but i dont recall making this change to this value
RESOLVED IN CODE WALKTHROUGH.
RESOLVED in CODE WALKTHROUGH.
Remove blank line.
Done.
Where is valveSensedStates being updated?
Yes, now call isDialInPumpRunning(). Done.
RESOLVED IN CODE WALKTHROUGH
Update function header.
Add blank line above these new constants.
dgSubMode not an input
Using a get function for the flag, but then setting value directly. Should there be a set function? Also applies to several functions below.
Can we get to this if condition before we've even set bloodPumpOcclusionAfterCartridgeInstall ? And, if so, is that a problem?
If only used for debug, this should be removed. If it is to be activated later, a more verbose comment is needed.
Uncomment or add a comment explaining why it is inactive.
RESOLVED in CODE WALKTHROUGH
Still see lines of code like this one that require a space after if (i.e. "if(..." should be "if (...").
Please remove commented code.
change comment from reservoirs to op mode
This variable is still being used when we trigger the alarm down at line 302. Should it be removed?
Should this entire function be commented out? It has the proper SW_CONFIG check to not raise alarms and the variables that being assigned here are local.
I think Darren is referring to a needed space after if (before opening parenthesis)? And not adding blank lines before if statements.
Update header to describe function parameter cmd.
Should we be raising this alarm with no data to log for debugging and/or service purposes?
Understood. Fixed. Thanks!
Done
Is this resolved?
Restore alarm when done.
What is the purpose of this "no event" event?
Comment says PreTreat, If checks for Treatment. Also space needed after if.
Blank lines before and after if.
Keep read for battery charger status here before end of list.
Why is this an alarm?
Updated header.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
