•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-13903-1 12 Oct 2022

Fixed. Thanks!

HD-DEN-13903-1 12 Oct 2022

Fixed. Thanks!

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13903-2 12 Oct 2022

Fixed. Thanks!

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13903-2 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13460-2 01 Sep 2022

Done.

DG-DEN-13834-1 12 Oct 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-13427-1 01 Sep 2022

I think we want to see more than this here to pass this phase of test.

DG-DEN-13427-1 29 Aug 2022

Align on "*" maybe?

HD-DEN-13712-1 29 Aug 2022

Why does this generate an alarm?

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Remove TODO

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

DG-DEN-13460-2 26 Aug 2022

U64 implies Unsigned, but this is signed.

DG-DEN-13834-1 12 Oct 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

Indent break or put {} around default code like other cases.

DG-DEN-13834-1 04 Oct 2022

This comment should precede the if statement above.

HD-DEN-14001-1 04 Oct 2022

Remove extra blank lines. Should only be 1 here.

HD-DEN-14001-1 18 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14001-1 18 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13903-2 12 Oct 2022

I think this flag should be set to FALSE in prior state as we transition to this state.

HD-DEN-14150-1 19 Oct 2022

Uncomment line.

HD-DEN-13903-2 21 Oct 2022

Fixed. Thanks!

DG-DEN-13460-2 29 Aug 2022

Should variables in if be reversed?

HD-DEN-13598-2 31 Aug 2022

Should this variable not have any assignment at initialization?

HD-DEN-13598-2 31 Aug 2022

Should we be raising this alarm with no data to log for debugging and/or service purposes?

HD-DEN-13712-1 29 Aug 2022

The UI will return to the Home screen during Disinfect Mode. This alarm is used to display the Disinfect Mode in progress while other tasks from Home.

HD-DEN-15367-1 12 Jun 2023

Done

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-13903-1 03 Oct 2022

The classes that have been removed are duplicates and wont be reverted. Please review the following lines:

PreTreatmentModeStates ( line 235) == PreTreatmentSubModes (line 82)

PreTreatmentSampleWaterStates ( line 249 ) == PreTreatmentSampleWaterStates ( line 96 )

PreTreatmentConsumableSelfTeststates ( line 257 ) == PreTreatmentConsumableSelfTeststates ( line 104 )

PreTreatmentNoCartSelfTestsStates ( line 268 ) == PreTreatmentNoCartSelfTestStates ( line 115 )

PreTreatmentDrySelfTestStates ( line 147 ) == PreTreatmentDrySelfTestsStates ( line 288 )

PreTreatmentPrimeStates ( line 163 ) == PreTreatmentPrimeStates ( line 304 )

StandbyStates ( line 344 ) == HDStandbyStates ( line 35 )

HD-DEN-13460-2 31 Aug 2022

Added a TODO to the commented code.

DG-DEN-13834-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 03 Oct 2022

I think battery pack status, battery pack remaining capacity and charger status would be in a separate message sent by a separate "publish" function, but the timing would just be whenever any of the 3 registers (or the 3rd of the 3 if they are always next to each other in enum in same order) has been read (call publish function from the cases where we read one of the 3 registers). If you publish after reading any of the 3, you could sometimes get broadcast 250ms apart. If you publish after reading the last of the 3 in a group (i.e. the status_1, remaining_capacity_1, charger_status_1), the spacing of the broadcast will depend on how many enums are between them.

HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13460-2 31 Aug 2022

Done.

HD-DEN-13427-1 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13801-1 21 Oct 2022

These inits are redundant as initPreTreatmentMode() is called just below which resets these flags already.

DG-DEN-13834-1 12 Oct 2022

Align.