•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-13460-2 01 Sep 2022

Done.

HD-DEN-14000-1 06 Oct 2022

Is this request for DG only? If so, rename enum to MSG_ID_REQUEST_DG_CPLD_STATUS.

HD-DEN-13460-2 01 Sep 2022

Thanks for the reminder.

HD-DEN-13834-1 12 Oct 2022

Is this a TODO? Can we just do it?

HD-DEN-13427-1 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Update function header. recvmsg

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 30 Aug 2022

Move to left margin? Several occurrences.

HD-DEN-13460-2 30 Aug 2022

Update header function.

HD-DEN-13460-2 30 Aug 2022

Update function header.

HD-DEN-13460-2 01 Sep 2022

remove blank line

HD-DEN-13903-1 12 Oct 2022

Fixed. Thanks!

HD-DEN-13903-2 12 Oct 2022

Fixed. Thanks!

HD-DEN-13903-1 12 Oct 2022

Remove param.

HD-DEN-13903-1 12 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-13834-1 12 Oct 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-14001-1 18 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13801-1 13 Oct 2022

Last value is U32 (this is a structure, not an array). "F" suffix is not required for typed assignments. Required for potentially untyped #defines /expressions / ...

HD-DEN-14000-1 12 Oct 2022

Remove extra blank line.

DG-DEN-13786-1 24 Oct 2022

Remove blank line.

DG-DEN-13786-1 24 Oct 2022

Is 30 sec permanent? If not, add TODO to revisit after RO control optimization is completed.

HD-DEN-13903-2 21 Oct 2022

Corrected comment above. Why are we changing BP flow rate at air trap lower level? Should be set to slow or fast on entry to this state (depending on whether this is 1st pass or not) and stay at that rate for duration of this pass.

HD-DEN-13801-1 21 Oct 2022

Remove extra blank line.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14175-1 03 Nov 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13801-1 28 Oct 2022

Add doxygen comment.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 03 Nov 2022

Done.

DG-DEN-14237-1 03 Nov 2022

Removed

DG-DEN-14237-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14237-1 03 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14237-1 03 Nov 2022

Can we just remove these?

DG-DEN-14237-1 03 Nov 2022

Remove this flag.

DG-DEN-14237-1 03 Nov 2022

Let's remove this code.

HD-DEN-14170-1 04 Nov 2022

I attempted to do this earlier in the process, but getTreatmentParameterF32() caused a fault when called too early (treat params not ready?).. So I kept it here after determining it was before UI needed it.

HD-DEN-14150-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14170-1 04 Nov 2022

Probably could just be if ( TRUE == isSyringePumpPreLoaded() ).

HD-DEN-14150-1 07 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14150-1 26 Oct 2022

Please update the DIP_ML_PER_MIN_FROM_PWM to reflect the changes in DIP_PWM_FROM_ML_PER_MIN. DIP_ML_PER_MIN_FROM_PWM should be the inverse equation of DIP_PWM_FROM_ML_PER_MIN. The rate in ml/min as an output with pwm as its input.

HD-DEN-14175-1 07 Nov 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14197-1 21 Nov 2022

I thought we changed this to include "DG" in the enum name. Why is it deleted again?

DG-DEN-13834-1 20 Sep 2022

No inputs.

HD-DEN-15367-1 12 Jun 2023

Done

DG-DEN-13460-2 21 Sep 2022

Should default trigger a s/w fault?

DG-DEN-13460-2 21 Sep 2022

This default is unreachable I think.

DG-DEN-13460-2 20 Sep 2022

This is legal, but odd looking. Can we define this structure type at top of module and have a normal declaration for baroCoeffs here?

DG-DEN-13460-2 20 Sep 2022

Can we add a comment explaining why these temp sensors are monitored and the rest are ignored?