•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13460-2 21 Sep 2022

Done.

DG-DEN-13460-2 21 Sep 2022

Done.

DG-DEN-13460-2 21 Sep 2022

Done.

HD-DEN-13460-2 16 Sep 2022

Remove extra blank line.

HD-DEN-13427-1 07 Sep 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13460-2 08 Sep 2022

Keep this blank line. Separate declarations from code.

DG-DEN-13427-1 07 Sep 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 17 Oct 2022

This should be the first if and the one above should just be an else (no if).

DG-DEN-13598-2 21 Sep 2022

Align these with first 2 #defines.

DIALIN-DEN-12716-1 08 Sep 2022

updated

DG-DEN-13598-2 21 Sep 2022

Not sure why this code is here - comment says remove so please remove these 2 lines of code.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13598-2 16 Sep 2022

Remove if not needed.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13598-2 16 Sep 2022

Update header

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13598-2 19 Sep 2022

Merge markers need to be removed.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13598-2 19 Sep 2022

Merge markers need to be removed.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13598-2 19 Sep 2022

Merge markers need to be removed.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13598-2 07 Sep 2022

Remove blank line.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13834-1 19 Sep 2022

F32 needs 0.0F init value.

DG-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15367-1 12 Jun 2023

Done

HD-DEN-14001-1 17 Oct 2022

Added.

HD-DEN-15367-1 07 Jun 2023

Add disinfectCancelReqID to header. Also argument stop.

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 18 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13834-1 14 Oct 2022

Removed for Phase 1B? Needs comment if so.

HD-DEN-14001-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 19 Sep 2022

Should 250 be #define?

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 17 Oct 2022

No.

HD-DEN-14001-1 18 Oct 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13903-2 21 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13903-2 21 Oct 2022

I think this check is for over-fill. Counter is for illegal level sensor readings. Over-fill check should have it's own counter (or use new persistence style) and we should reset that separate counter in the "else" condition.

HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!