•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-14101-1 21 Oct 2022

Fixed. Thanks!

HD-DEN-13801-1 21 Oct 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13786-1 24 Oct 2022

Can we do s/w fault now?

DG-DEN-13786-1 24 Oct 2022

Should use of TRo here be for DVT (if V3 s/w config, continue to use TDi)?

DG-DEN-13786-1 24 Oct 2022

This file has been removed.

DG-DEN-13786-1 24 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13786-1 24 Oct 2022

Remove comment.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

Remove blank line.

HD-DEN-13801-1 28 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13801-1 28 Oct 2022

Align comment.

DG-DEN-14175-1 28 Oct 2022

Not clear this needs to be done. I believe is properly handled in heaters when you get a temperature value and configured for V3.

DG-DEN-14237-1 03 Nov 2022

This function will still override if there any alarms. Are we going to change the order of status report?

HD-DEN-14170-1 04 Nov 2022

Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.

DG-DEN-14237-1 03 Nov 2022

Removed

DG-DEN-14237-1 03 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14237-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14237-1 03 Nov 2022

Can we just remove this code?

DG-DEN-14237-1 03 Nov 2022

Remove the TRUE case. Just need the else now.

DG-DEN-14237-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14150-1 04 Nov 2022

Done.

HD-DEN-14170-1 04 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14175-1 07 Nov 2022

Looks like blank line is still there.

HD-DEN-14170-1 07 Nov 2022

RESOLVED IN CODE WLAKTHROUGH

HD-DEN-14170-1 07 Nov 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14175-1 07 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14197-1 21 Nov 2022

Fixed. Thanks!

HD-DEN-14150-1 18 Oct 2022

Removed the commented-out line.

DG-DEN-14000-1 21 Nov 2022

Done.

DG-DEN-14000-1 21 Nov 2022

Add extra blank line here.

DG-DEN-14000-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Nov 2022

Remove extra blank line.

DG-DEN-13460-2 12 Sep 2022

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

DG-DEN-13427-1 07 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13460-2 20 Sep 2022

Keep blank line.

DG-DEN-13427-1 09 Sep 2022

This block of code is being flagged as a change into my branch but it is not reflected on either commit listed above. Header will be updated in DEN-13801 branch.

DG-DEN-13598-2 21 Sep 2022

Move this to after execHeaters() and before #endif.

HD-DEN-13598-2 16 Sep 2022

Remove

DG-DEN-13598-2 19 Sep 2022

Merge markers need to be removed.

DG-DEN-13598-2 19 Sep 2022

Already removed the merge markers.

HD-DEN-13712-1 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13598-2 20 Sep 2022

Already removed the marge markers.

DG-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13460-2 12 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 14 Oct 2022

RESOLVED in CODE WALKTHROUGH.